Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: media/base/android/media_codec_player.h

Issue 1242913004: MediaCodecPlayer implementation (stage 3 - browser seek and surface change) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mtplayer-seek
Patch Set: Fixed the check whether surface is empty, faster stopping after SyncStop, cleanup Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/media_codec_player.h
diff --git a/media/base/android/media_codec_player.h b/media/base/android/media_codec_player.h
index cb1ae407dbb6dff6a6da4efce02d85970e330d57..854b7c226a00199df57e2c3096c5b21431689d15 100644
--- a/media/base/android/media_codec_player.h
+++ b/media/base/android/media_codec_player.h
@@ -155,6 +155,8 @@ class MEDIA_EXPORT MediaCodecPlayer : public MediaPlayerAndroid,
typedef base::Callback<void(const base::TimeDelta& current_timestamp)>
SeekDoneCallback;
+ typedef base::Callback<void(int)> ErrorCallback;
+
// Constructs a player with the given ID and demuxer. |manager| must outlive
// the lifetime of this object.
MediaCodecPlayer(int player_id,
@@ -205,6 +207,12 @@ class MEDIA_EXPORT MediaCodecPlayer : public MediaPlayerAndroid,
STATE_ERROR,
};
+ enum StartStatus {
+ START_OK = 0,
+ START_BROWSER_SEEK_REQUIRED,
+ START_FAILED,
+ };
+
// Cached values for the manager.
struct MediaMetadata {
base::TimeDelta duration;
@@ -244,8 +252,6 @@ class MEDIA_EXPORT MediaCodecPlayer : public MediaPlayerAndroid,
// Operations called from the state machine.
void SetState(PlayerState new_state);
- void SetPendingSurface(gfx::ScopedJavaSurface surface);
- bool HasPendingSurface();
void SetPendingStart(bool need_to_start);
bool HasPendingStart();
void SetPendingSeek(base::TimeDelta timestamp);
@@ -254,7 +260,8 @@ class MEDIA_EXPORT MediaCodecPlayer : public MediaPlayerAndroid,
bool HasAudio();
void SetDemuxerConfigs(const DemuxerConfigs& configs);
void StartPrefetchDecoders();
- void StartPlaybackDecoders();
+ void StartPlaybackOrBrowserSeek();
+ StartStatus StartPlaybackDecoders();
void StopDecoders();
void RequestToStopDecoders();
void RequestDemuxerSeek(base::TimeDelta seek_time,
@@ -287,6 +294,7 @@ class MEDIA_EXPORT MediaCodecPlayer : public MediaPlayerAndroid,
TimeUpdateCallback time_update_cb_;
base::Closure completion_cb_;
SeekDoneCallback seek_done_cb_;
+ ErrorCallback error_cb_;
// A callback that updates metadata cache and calls the manager.
MetadataChangedCallback metadata_changed_cb_;
@@ -298,7 +306,7 @@ class MEDIA_EXPORT MediaCodecPlayer : public MediaPlayerAndroid,
// Error callback is posted by decoders or by this class itself if we cannot
// configure or start decoder.
- base::Closure error_cb_;
+ base::Closure internal_error_cb_;
// Total duration reported by demuxer.
base::TimeDelta duration_;

Powered by Google App Engine
This is Rietveld 408576698