media/base/android/media_codec_video_decoder.h - Issue 1242913004: MediaCodecPlayer implementation (stage 3 - browser seek and surface change)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_codec_video_decoder.h

Issue 1242913004: MediaCodecPlayer implementation (stage 3 - browser seek and surface change) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mtplayer-seek

Patch Set: Fixed SeekTo() followed by Release() and added uunit tests for this case Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/base/android/media_codec_player.cc ('K') | « media/base/android/media_codec_player_unittest.cc ('k') | media/base/android/media_codec_video_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_codec_video_decoder.h

diff --git a/media/base/android/media_codec_video_decoder.h b/media/base/android/media_codec_video_decoder.h

index ed455c84bbd88a9c9a9620f426060d71070fc883..8b6de8e91d7b36722fd4d5c5a23eb06382add3c1 100644

--- a/media/base/android/media_codec_video_decoder.h

+++ b/media/base/android/media_codec_video_decoder.h

@@ -44,10 +44,10 @@ class MediaCodecVideoDecoder : public MediaCodecDecoder {

void ReleaseDecoderResources() override;

// Stores the video surface to use with upcoming Configure()

- void SetPendingSurface(gfx::ScopedJavaSurface surface);

+ void SetVideoSurface(gfx::ScopedJavaSurface surface);

// Returns true if there is a video surface to use.

- bool HasPendingSurface() const;

+ bool HasVideoSurface() const;

protected:

bool IsCodecReconfigureNeeded(const DemuxerConfigs& curr,

@@ -62,7 +62,7 @@ class MediaCodecVideoDecoder : public MediaCodecDecoder {

bool eos_encountered) override;

int NumDelayedRenderTasks() const override;

- void ReleaseDelayedBuffers() override;

+ void ClearDelayedBuffers(bool release) override;

#ifndef NDEBUG

void VerifyUnitIsKeyFrame(const AccessUnit* unit) const override;