MediaCodecPlayer implementation (stage 3 - browser seek and surface change)

media/base/android/media_codec_video_decoder.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/android/media_codec_video_decoder.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "media/base/android/media_codec_bridge.h"
 #include "media/base/buffers.h"
@@ skipping 57 matching lines @@
 void MediaCodecVideoDecoder::ReleaseDecoderResources() {
   DCHECK(media_task_runner_->BelongsToCurrentThread());
 
   DVLOG(1) << class_name() << "::" << __FUNCTION__;
 
   MediaCodecDecoder::ReleaseDecoderResources();
   surface_ = gfx::ScopedJavaSurface();
   delayed_buffers_.clear();
 }
 
-void MediaCodecVideoDecoder::SetPendingSurface(gfx::ScopedJavaSurface surface) {
+void MediaCodecVideoDecoder::SetVideoSurface(gfx::ScopedJavaSurface surface) {
   DCHECK(media_task_runner_->BelongsToCurrentThread());
 
+  DVLOG(1) << class_name() << "::" << __FUNCTION__
+           << (surface.IsEmpty() ? " empty" : " non-empty");
+
   surface_ = surface.Pass();
 
-  if (surface_.IsEmpty()) {
-    // Synchronously stop decoder thread and release MediaCodec
-    ReleaseDecoderResources();
-  }
+  needs_reconfigure_ = true;
 }
 
-bool MediaCodecVideoDecoder::HasPendingSurface() const {
+bool MediaCodecVideoDecoder::HasVideoSurface() const {
   DCHECK(media_task_runner_->BelongsToCurrentThread());
 
   return !surface_.IsEmpty();
 }
 
 bool MediaCodecVideoDecoder::IsCodecReconfigureNeeded(
     const DemuxerConfigs& curr,
     const DemuxerConfigs& next) const {
   if (curr.video_codec != next.video_codec ||
       curr.is_video_encrypted != next.is_video_encrypted) {
@@ skipping 13 matching lines @@
 }
 
 MediaCodecDecoder::ConfigStatus MediaCodecVideoDecoder::ConfigureInternal() {
   DCHECK(media_task_runner_->BelongsToCurrentThread());
 
   DVLOG(1) << class_name() << "::" << __FUNCTION__;
 
   // If we cannot find a key frame in cache, the browser seek is needed.
   if (!au_queue_.RewindToLastKeyFrame()) {
     DVLOG(1) << class_name() << "::" << __FUNCTION__ << " key frame required";
+    return CONFIG_KEY_FRAME_REQUIRED;
+  }
 
-    // The processing of CONFIG_KEY_FRAME_REQUIRED is not implemented yet,
-    // return error for now.
-    // TODO(timav): Replace this with the following line together with
-    // implementing the browser seek:
-    // return CONFIG_KEY_FRAME_REQUIRED;
+  if (configs_.video_codec == kUnknownVideoCodec) {
+    DVLOG(0) << class_name() << "::" << __FUNCTION__
+             << " configuration parameters are required";
     return CONFIG_FAILURE;
   }
 
   // TODO(timav): implement DRM.
   // bool is_secure = is_content_encrypted() && drm_bridge() &&
   //    drm_bridge()->IsProtectedSurfaceRequired();
 
   bool is_secure = false;  // DRM is not implemented
 
   if (surface_.IsEmpty()) {
@@ skipping 98 matching lines @@
 }
 
 void MediaCodecVideoDecoder::ReleaseDelayedBuffers() {
   // Media thread
   // Called when there is no decoder thread
   for (int index : delayed_buffers_)
     media_codec_bridge_->ReleaseOutputBuffer(index, false);
   delayed_buffers_.clear();
 }
 
+void MediaCodecVideoDecoder::ClearDelayedBuffers() {

[qinmin, 2015/07/22 17:30:33]

I think you can merge this function with ReleaseDelayedBuffers(), something like
ClearDelayedBuffers(bool release_output_buffer)

[Tima Vaisburd, 2015/07/23 00:37:49]

Done.

+  // Media thread
+  delayed_buffers_.clear();
+}
+
 #ifndef NDEBUG
 void MediaCodecVideoDecoder::VerifyUnitIsKeyFrame(
     const AccessUnit* unit) const {
   // The first video frame in a sequence must be a key frame or stand-alone EOS.
   DCHECK(unit);
   bool stand_alone_eos = unit->is_end_of_stream && unit->data.empty();
   DCHECK(stand_alone_eos || unit->is_key_frame);
 }
 #endif
 
@@ skipping 14 matching lines @@
 
   // |update_current_time_cb_| might be null if there is audio stream.
   // Do not update current time for stand-alone EOS frames.
   if (!update_current_time_cb_.is_null() && !(eos_encountered && !size)) {
     media_task_runner_->PostTask(FROM_HERE,
                                  base::Bind(update_current_time_cb_, pts, pts));
   }
 }
 
 }  // namespace media