Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Issue 1242873004: Delete redundant call to ServiceProcess::Teardown. (Closed)

Created:
5 years, 5 months ago by Michael van Ouwerkerk
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete redundant call to ServiceProcess::Teardown. Currently Teardown is called twice on shutdown. The ServiceProcess is on the stack. It will call Teardown from its destructor when ServiceProcessMain returns. It looks like this redundancy has been there since the service process was first introduced in: https://codereview.chromium.org/2001009/ Committed: https://crrev.com/98e52c65f19c80867ba2b15b12c80e4ded8d950c Cr-Commit-Position: refs/heads/master@{#339707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/service/service_main.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael van Ouwerkerk
Vitaly, could you take a look please?
5 years, 5 months ago (2015-07-21 09:45:23 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 5 months ago (2015-07-21 16:54:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242873004/1
5 years, 5 months ago (2015-07-21 17:23:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 18:43:19 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 18:44:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98e52c65f19c80867ba2b15b12c80e4ded8d950c
Cr-Commit-Position: refs/heads/master@{#339707}

Powered by Google App Engine
This is Rietveld 408576698