Issue 1242873003: Fix dart_pkg.py build crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1242873003: Fix dart_pkg.py build crash (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
Cutch

CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix dart_pkg.py build crash We need to work in absolute paths because os.path.exists("foo/..") is False but os.mkdirs("foo/..") will generate an error. R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/a015ec3f7c4ceaf60826754f790433f15ecd57ef

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	mojo/public/tools/dart_pkg.py	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

See https://travis-ci.org/domokit/sky_engine/builds/71886946 for an example build failure.

5 years, 5 months ago (2015-07-21 06:21:35 UTC) #2

abarth-chromium

5 years, 5 months ago (2015-07-21 14:58:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a015ec3f7c4ceaf60826754f790433f15ecd57ef (presubmit successful).

Expand Messages | Collapse Messages