Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1242863003: Adding CHECKED_OUT_VERSION to .gitignore. (Closed)

Created:
5 years, 5 months ago by bradn
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adding CHECKED_OUT_VERSION to .gitignore. Adding CHECKED_OUT_VERSION in test/simdjs so that the bots don't revert and redownload each time. LOG=N BUG=None TEST=None R=littledan@chromium.org,machenbach@chromium.org Committed: https://crrev.com/84a6db99dc262062981d1fdd0e597eaa2628d352 Cr-Commit-Position: refs/heads/master@{#29826}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
bradn
5 years, 5 months ago (2015-07-23 22:43:09 UTC) #1
Dan Ehrenberg
lgtm
5 years, 5 months ago (2015-07-23 23:35:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1242863003/1
5 years, 5 months ago (2015-07-24 03:54:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-24 06:16:51 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/84a6db99dc262062981d1fdd0e597eaa2628d352 Cr-Commit-Position: refs/heads/master@{#29826}
5 years, 5 months ago (2015-07-24 06:17:12 UTC) #6
Michael Achenbach
lgtm
5 years, 5 months ago (2015-07-24 06:59:38 UTC) #7
Michael Achenbach
5 years, 5 months ago (2015-07-24 12:55:43 UTC) #8
Message was sent while issue was closed.
This seems to work now, thanks!

Powered by Google App Engine
This is Rietveld 408576698