Issue 12428016: Add an icon file required for another patch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12428016: Add an icon file required for another patch (Closed)

Created:
7 years, 9 months ago by Vladislav Kaznacheev

Modified:
7 years, 9 months ago

Reviewers:

CC:
chromium-reviews, vsevik, yurys, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Add an icon file required for another patch Patch https://chromiumcodereview.appspot.com/12319114/ requires an icon but the try bots would not accept a binary file. BUG=179342 TBR=pfeldman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187263

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -0 lines)			Patch
	A +	chrome/test/data/devtools/target_list/favicon.png	View		Binary file		0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/12428016/1

7 years, 9 months ago (2013-03-11 09:34:09 UTC) #1

commit-bot: I haz the power

Can't process patch for file chrome/test/data/devtools/target_list/favicon.png. Binary file support is temporarilly disabled due to a ...

7 years, 9 months ago (2013-03-11 09:34:10 UTC) #2

Vladislav Kaznacheev

7 years, 9 months ago (2013-03-11 09:38:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r187263 (presubmit successful).