Refactor most c/b/profiles calls to ProfileInfoCache.

chrome/browser/profiles/profile_metrics.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_metrics.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/profiles/profile_info_cache.h"
+#include "chrome/browser/profiles/profile_attributes_entry.h"
+#include "chrome/browser/profiles/profile_attributes_storage.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/signin/signin_header_helper.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/installer/util/google_update_settings.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/user_metrics.h"
 
 namespace {
 
@@ skipping 41 matching lines @@
   if (manager) {
     user_data_dir = manager->user_data_dir();
   }
   if (profile_path == user_data_dir.AppendASCII(chrome::kInitialProfile)) {
     metric = ProfileMetrics::ORIGINAL;
   }
   return metric;
 }
 
 void LogLockedProfileInformation(ProfileManager* manager) {
-  const ProfileInfoCache& info_cache = manager->GetProfileInfoCache();
-  size_t number_of_profiles = info_cache.GetNumberOfProfiles();
+  ProfileAttributesStorage& storage = manager->GetProfileAttributesStorage();
+  std::vector<ProfileAttributesEntry*> entries =
+      storage.GetAllProfilesAttributes();
 
   base::Time now = base::Time::Now();
   const int kMinutesInProfileValidDuration =
       base::TimeDelta::FromDays(28).InMinutes();
-  for (size_t i = 0; i < number_of_profiles; ++i) {
+  for (ProfileAttributesEntry* entry: entries) {
     // Find when locked profiles were locked
-    if (info_cache.ProfileIsSigninRequiredAtIndex(i)) {
-      base::TimeDelta time_since_lock = now -
-          info_cache.GetProfileActiveTimeAtIndex(i);
+    if (entry->IsSigninRequired()) {
+      base::TimeDelta time_since_lock = now - entry->GetActiveTime();
       // Specifying 100 buckets for the histogram to get a higher level of
       // granularity in the reported data, given the large number of possible
       // values (kMinutesInProfileValidDuration > 40,000).
       UMA_HISTOGRAM_CUSTOM_COUNTS("Profile.LockedProfilesDuration",
                                   time_since_lock.InMinutes(),
                                   1,
                                   kMinutesInProfileValidDuration,
                                   100);
     }
   }
 }
 
-bool HasProfileAtIndexBeenActiveSince(const ProfileInfoCache& info_cache,
-                                      int index,
+bool HasProfileAtIndexBeenActiveSince(const ProfileAttributesEntry* entry,
                                       const base::Time& active_limit) {
 #if !defined(OS_ANDROID) && !defined(OS_IOS)
   // TODO(mlerman): iOS and Android should set an ActiveTime in the
   // ProfileInfoCache. (see ProfileManager::OnBrowserSetLastActive)
-  if (info_cache.GetProfileActiveTimeAtIndex(index) < active_limit)
+  if (entry->GetActiveTime() < active_limit)
     return false;
 #endif
   return true;
 }
 
 }  // namespace
 
 enum ProfileAvatar {
   AVATAR_GENERIC = 0,       // The names for avatar icons
   AVATAR_GENERIC_AQUA,
@@ skipping 22 matching lines @@
   AVATAR_NOTE,
   AVATAR_SUN_CLOUD,
   AVATAR_PLACEHOLDER,
   AVATAR_UNKNOWN,           // 27
   AVATAR_GAIA,              // 28
   NUM_PROFILE_AVATAR_METRICS
 };
 
 bool ProfileMetrics::CountProfileInformation(ProfileManager* manager,
                                              ProfileCounts* counts) {
-  const ProfileInfoCache& info_cache = manager->GetProfileInfoCache();
-  size_t number_of_profiles = info_cache.GetNumberOfProfiles();
-  counts->total = number_of_profiles;
+  ProfileAttributesStorage& storage = manager->GetProfileAttributesStorage();
+  counts->total = storage.GetNumberOfProfiles();
 
   // Ignore other metrics if we have no profiles.
-  if (!number_of_profiles)
+  if (!counts->total)
     return false;
 
   // Maximum age for "active" profile is 4 weeks.
   base::Time oldest = base::Time::Now() -
       base::TimeDelta::FromDays(kMaximumDaysOfDisuse);
 
-  for (size_t i = 0; i < number_of_profiles; ++i) {
-    if (!HasProfileAtIndexBeenActiveSince(info_cache, i, oldest)) {
+  std::vector<ProfileAttributesEntry*> entries =
+      storage.GetAllProfilesAttributes();
+  for (ProfileAttributesEntry* entry: entries) {

[Mike Lerman, 2015/08/06 16:06:20]

nit: space between entry and :

+    if (!HasProfileAtIndexBeenActiveSince(entry, oldest)) {
       counts->unused++;
     } else {
-      if (info_cache.ProfileIsSupervisedAtIndex(i))
+      if (entry->IsSupervised())
         counts->supervised++;
-      if (info_cache.ProfileIsAuthenticatedAtIndex(i)) {
+      if (entry->IsAuthenticated()) {
         counts->signedin++;
-        if (info_cache.IsUsingGAIAPictureOfProfileAtIndex(i))
+        if (entry->IsUsingGAIAPicture())
           counts->gaia_icon++;
-        if (info_cache.ProfileIsAuthErrorAtIndex(i))
+        if (entry->IsAuthError())
           counts->auth_errors++;
       }
     }
   }
   return true;
 }
 
 void ProfileMetrics::UpdateReportedProfilesStatistics(ProfileManager* manager) {
 #if defined(OS_WIN) || defined(OS_MACOSX)
   ProfileCounts counts;
@@ skipping 368 matching lines @@
   UMA_HISTOGRAM_ENUMERATION("Profile.SyncSignIn",
                             GetProfileType(profile_path),
                             NUM_PROFILE_TYPE_METRICS);
 }
 
 void ProfileMetrics::LogProfileUpdate(const base::FilePath& profile_path) {
   UMA_HISTOGRAM_ENUMERATION("Profile.Update",
                             GetProfileType(profile_path),
                             NUM_PROFILE_TYPE_METRICS);
 }