Refactor most c/b/profiles calls to ProfileInfoCache.

chrome/browser/profiles/profile_attributes_entry.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/i18n/case_conversion.h"
 #include "chrome/browser/profiles/profile_attributes_entry.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 
 ProfileAttributesEntry::ProfileAttributesEntry()
     : profile_info_cache_(nullptr),
       profile_path_(base::FilePath()) {}
 
 void ProfileAttributesEntry::Initialize(
     ProfileInfoCache* cache, const base::FilePath& path) {
   DCHECK(!profile_info_cache_);
@@ skipping 116 matching lines @@
 }
 
 void ProfileAttributesEntry::SetName(const base::string16& name) {
   profile_info_cache_->SetNameOfProfileAtIndex(profile_index(), name);
 }
 
 void ProfileAttributesEntry::SetShortcutName(const base::string16& name) {
   profile_info_cache_->SetShortcutNameOfProfileAtIndex(profile_index(), name);
 }
 
+void ProfileAttributesEntry::SetActiveTime() {
+  profile_info_cache_->SetProfileActiveTimeAtIndex(profile_index());
+}
+
 void ProfileAttributesEntry::SetIsOmitted(bool is_omitted) {
   profile_info_cache_->SetIsOmittedProfileAtIndex(profile_index(), is_omitted);
 }
 
 void ProfileAttributesEntry::SetSupervisedUserId(const std::string& id) {
   profile_info_cache_->SetSupervisedUserIdOfProfileAtIndex(profile_index(), id);
 }
 
 void ProfileAttributesEntry::SetLocalAuthCredentials(const std::string& auth) {
   profile_info_cache_->SetLocalAuthCredentialsOfProfileAtIndex(
@@ skipping 59 matching lines @@
     const std::string& gaia_id, const base::string16& user_name) {
   profile_info_cache_->SetAuthInfoOfProfileAtIndex(
       profile_index(), gaia_id, user_name);
 }
 
 size_t ProfileAttributesEntry::profile_index() const {
   size_t index = profile_info_cache_->GetIndexOfProfileWithPath(profile_path_);
   DCHECK(index < profile_info_cache_->GetNumberOfProfiles());
   return index;
 }
+
+bool ProfileAttributesEntry::LessThan(const ProfileAttributesEntry& other)
+    const {
+  base::string16 lower_name = base::i18n::ToLower(GetName());
+  base::string16 other_lower_name = base::i18n::ToLower(other.GetName());
+
+  int name_compare = lower_name.compare(other_lower_name);
+
+  if (name_compare == 0) {
+    return profile_info_cache_->CacheKeyFromProfilePath(GetPath()).compare(

[Mike Lerman, 2015/08/06 16:06:19]

Why not just run compare on GetPath() (or some derivative)?

+           profile_info_cache_->CacheKeyFromProfilePath(other.GetPath())) < 0;
+  }
+  return name_compare < 0;
+}