Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: tonic/dart_error.cc

Issue 1242773003: Use the tonic namespace for tonic + resulting build fixes (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tonic/dart_error.h ('k') | tonic/dart_exception_factory.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tonic/dart_error.h" 5 #include "tonic/dart_error.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 namespace blink { 9 namespace tonic {
10 10
11 namespace DartError { 11 namespace DartError {
12 12
13 const char kInvalidArgument[] = "Invalid argument."; 13 const char kInvalidArgument[] = "Invalid argument.";
14 14
15 } // namespace DartError 15 } // namespace DartError
16 16
17 bool LogIfError(Dart_Handle handle) { 17 bool LogIfError(Dart_Handle handle) {
18 if (Dart_IsError(handle)) { 18 if (Dart_IsError(handle)) {
19 LOG(ERROR) << Dart_GetError(handle); 19 LOG(ERROR) << Dart_GetError(handle);
20 20
21 // Only unhandled exceptions have stacktraces. 21 // Only unhandled exceptions have stacktraces.
22 if (!Dart_ErrorHasException(handle)) 22 if (!Dart_ErrorHasException(handle))
23 return true; 23 return true;
24 24
25 Dart_Handle stacktrace = Dart_ErrorGetStacktrace(handle); 25 Dart_Handle stacktrace = Dart_ErrorGetStacktrace(handle);
26 const char* stacktrace_cstr = ""; 26 const char* stacktrace_cstr = "";
27 Dart_StringToCString(Dart_ToString(stacktrace), &stacktrace_cstr); 27 Dart_StringToCString(Dart_ToString(stacktrace), &stacktrace_cstr);
28 LOG(ERROR) << stacktrace_cstr; 28 LOG(ERROR) << stacktrace_cstr;
29 return true; 29 return true;
30 } 30 }
31 return false; 31 return false;
32 } 32 }
33 33
34 } // namespace blink 34 } // namespace tonic
OLDNEW
« no previous file with comments | « tonic/dart_error.h ('k') | tonic/dart_exception_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698