Use org.gnome.desktop.interface text-scaling-factor directly

Use org.gnome.desktop.interface text-scaling-factor directly

gtk-xft-dpi is updated based on this value, so using this directly makes more sense.

BUG=511580
TEST=manual.

Committed: https://crrev.com/42de8ba1ba55502417670a820b5bd57017a6cd29
Cr-Commit-Position: refs/heads/master@{#339957}

[oshima, 2015-07-20 23:08:55]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-20 23:09:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1242753005/20001

[commit-bot: I haz the power, 2015-07-20 23:43:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-20 23:43:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2015-07-20 23:53:40]

oshima@chromium.org changed reviewers:
+ estade@chromium.org

[Evan Stade, 2015-07-21 00:31:43]

seems legit, but I don't really know with certainty. Rubbery lgtm.

[stapelberg, 2015-07-21 12:35:29]

stapelberg@google.com changed reviewers:
+ stapelberg@google.com

[stapelberg, 2015-07-21 14:16:09]

lgtm

I built Chrome with this CL patched in and can confirm that it works as
intended.

[oshima, 2015-07-21 16:50:52]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-21 16:51:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1242753005/40001

[commit-bot: I haz the power, 2015-07-21 17:27:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-21 17:27:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2015-07-21 18:13:15]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-21 18:14:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1242753005/60001

[oshima, 2015-07-21 18:15:09]

Patchset #4 (id:60001) has been deleted

[oshima, 2015-07-21 18:15:14]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-21 18:16:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1242753005/80001

[commit-bot: I haz the power, 2015-07-21 18:34:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-21 18:34:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2015-07-21 19:28:35]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-21 19:29:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1242753005/120001

[oshima, 2015-07-21 19:50:38]

estade@, can you take another look?

1) I have to check if the schema exists. On non-gnome environment, I have to
check if the scheme exists.
2) I have to use deprecated API (g_settings_list_schemas) because it's not
always available on the platform we support and CQ bots.

[commit-bot: I haz the power, 2015-07-21 20:29:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-21 20:29:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2015-07-21 20:46:13]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-21 20:46:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1242753005/140001

[commit-bot: I haz the power, 2015-07-21 20:48:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-21 20:48:23]

Dry run: Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[oshima, 2015-07-21 20:54:43]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-21 20:55:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1242753005/160001

[commit-bot: I haz the power, 2015-07-21 22:06:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-21 22:06:05]

Dry run: This issue passed the CQ dry run.

[oshima, 2015-07-21 22:56:49]

kbr@ -> pixel_expectations.py

This CL fixes the scale factor computations, which affected nvidia bots. I'll
update the page set revision and revert the expectation in follow up CLs.

[oshima, 2015-07-21 22:57:57]

oshima@chromium.org changed reviewers:
+ kbr@chromium.org

[oshima, 2015-07-21 22:57:57]

# oops, hit send too early.

kbr@ -> pixel_expectations.py

This CL fixes the scale factor computations, which affected nvidia bots. I'll
update the page set revision and revert the expectation in follow up CLs.

estade@, please review this again.

stapelberg@, can you test this patch again?

[Ken Russell (switch to Gerrit), 2015-07-21 23:08:12]

LGTM assuming the expectations are updated in a follow-on CL.

[oshima, 2015-07-22 16:38:05]

estate@: ping?

[Evan Stade, 2015-07-22 17:53:30]

https://codereview.chromium.org/1242753005/diff/160001/chrome/browser/ui/libg...
File chrome/browser/ui/libgtk2ui/gtk2_ui.cc (right):

https://codereview.chromium.org/1242753005/diff/160001/chrome/browser/ui/libg...
chrome/browser/ui/libgtk2ui/gtk2_ui.cc:430: bool HasSchema(const char*
schema_name) {
I see this is copied from elsewhere in chrome, but why is it not a for loop?
Also, I'd just inline it till it's needed in more than one place in this file.

https://codereview.chromium.org/1242753005/diff/160001/chrome/browser/ui/libg...
chrome/browser/ui/libgtk2ui/gtk2_ui.cc:445: GSettings* settings =
g_settings_new(kDesktopInterfaceSchema);
can we cache the return value since the scale factor doesn't update anyway? From
poking around online, it seems that g_settings_new might be somewhat expensive,
and it's unclear to me how often GetDeviceScaleFactor is called.

[oshima, 2015-07-22 18:56:51]

Patchset #9 (id:180001) has been deleted

[oshima, 2015-07-22 18:59:52]

Patchset #9 (id:200001) has been deleted

[oshima, 2015-07-22 19:01:04]

https://codereview.chromium.org/1242753005/diff/160001/chrome/browser/ui/libg...
File chrome/browser/ui/libgtk2ui/gtk2_ui.cc (right):

https://codereview.chromium.org/1242753005/diff/160001/chrome/browser/ui/libg...
chrome/browser/ui/libgtk2ui/gtk2_ui.cc:430: bool HasSchema(const char*
schema_name) {
On 2015/07/22 17:53:30, Evan Stade wrote:
> I see this is copied from elsewhere in chrome, but why is it not a for loop?

I just didn't feel a need to change or refactor. Done.

> Also, I'd just inline it till it's needed in more than one place in this file.

Sure.

https://codereview.chromium.org/1242753005/diff/160001/chrome/browser/ui/libg...
chrome/browser/ui/libgtk2ui/gtk2_ui.cc:445: GSettings* settings =
g_settings_new(kDesktopInterfaceSchema);
On 2015/07/22 17:53:30, Evan Stade wrote:
> can we cache the return value since the scale factor doesn't update anyway?
From
> poking around online, it seems that g_settings_new might be somewhat
expensive,
> and it's unclear to me how often GetDeviceScaleFactor is called.

This is called only once as the value is assigned to static, but I should use
the rounded value instead. Thank you for pointing this out.

[oshima, 2015-07-22 19:01:12]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-22 19:02:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1242753005/180002

[Evan Stade, 2015-07-22 20:03:36]

lgtm

[commit-bot: I haz the power, 2015-07-22 20:11:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-22 20:11:57]

Dry run: This issue passed the CQ dry run.

[oshima, 2015-07-22 21:31:06]

The CQ bit was checked by oshima@chromium.org

[oshima, 2015-07-22 21:31:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
stapelberg@google.com, kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/1242753005/#ps180002
(title: " ")

[commit-bot: I haz the power, 2015-07-22 21:33:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1242753005/180002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1242753005/180002

[commit-bot: I haz the power, 2015-07-22 22:17:55]

Committed patchset #9 (id:180002)

[commit-bot: I haz the power, 2015-07-22 22:18:32]

Patchset 9 (id:??) landed as
https://crrev.com/42de8ba1ba55502417670a820b5bd57017a6cd29
Cr-Commit-Position: refs/heads/master@{#339957}