Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1242743003: Implements RLZTrackerDelegate on iOS. (Closed)

Created:
5 years, 5 months ago by sdefresne
Modified:
5 years, 5 months ago
Reviewers:
droger
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implements RLZTrackerDelegate on iOS. Reland of https://codereview.chromium.org/1242373002/ but correctly rebased on ToT. BUG=511570 Committed: https://crrev.com/0d982f9a85f341ca52a558350afef661a3b17c95 Cr-Commit-Position: refs/heads/master@{#339696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -0 lines) Patch
M ios/chrome/browser/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/pref_names.cc View 1 chunk +1 line, -0 lines 0 comments Download
A ios/chrome/browser/rlz/rlz_tracker_delegate_impl.h View 1 chunk +57 lines, -0 lines 0 comments Download
A ios/chrome/browser/rlz/rlz_tracker_delegate_impl.cc View 1 chunk +137 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
Reland of https://codereview.chromium.org/1242373002/. PTAL.
5 years, 5 months ago (2015-07-21 17:47:31 UTC) #2
droger
lgtm
5 years, 5 months ago (2015-07-21 17:51:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242743003/1
5 years, 5 months ago (2015-07-21 17:56:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 18:10:12 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 18:11:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d982f9a85f341ca52a558350afef661a3b17c95
Cr-Commit-Position: refs/heads/master@{#339696}

Powered by Google App Engine
This is Rietveld 408576698