Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1242663002: Fixing patch level so it reflects the version in the tags (Closed)

Created:
5 years, 5 months ago by Michael Hablich
Modified:
5 years, 5 months ago
Reviewers:
Michael Achenbach
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@4.4
Target Ref:
refs/pending/branch-heads/4.4
Project:
v8
Visibility:
Public.

Description

Fixing patch level so it reflects the version in the tags BUG= R=machenbach@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Patch Set 2 : Fix version file so merge scripts work again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/v8-version.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Hablich
5 years, 5 months ago (2015-07-20 08:34:14 UTC) #1
Michael Achenbach
lgtm
5 years, 5 months ago (2015-07-20 08:39:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242663002/20001
5 years, 5 months ago (2015-07-20 08:40:27 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
5 years, 5 months ago (2015-07-20 08:40:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242663002/20001
5 years, 5 months ago (2015-07-20 08:41:07 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 08:41:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698