Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1242623002: [es6] Array.prototype[Symbol.iterator].name should be 'values' (Closed)

Created:
5 years, 5 months ago by adamk
Modified:
5 years, 5 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Array.prototype[Symbol.iterator].name should be 'values' R=littledan@chromium.org BUG=v8:4311 LOG=n Committed: https://crrev.com/3a74348e09125355d680200e59216bf4f6262dcf Cr-Commit-Position: refs/heads/master@{#29794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/array-iterator.js View 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/es6/array-iterator.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
adamk
5 years, 5 months ago (2015-07-17 20:40:12 UTC) #1
adamk
ping? (no hurry on this, but it's just simple enough)
5 years, 5 months ago (2015-07-22 21:23:05 UTC) #2
Dan Ehrenberg
lgtm
5 years, 5 months ago (2015-07-22 21:26:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1242623002/1
5 years, 5 months ago (2015-07-22 22:26:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 05:50:31 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 05:50:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a74348e09125355d680200e59216bf4f6262dcf
Cr-Commit-Position: refs/heads/master@{#29794}

Powered by Google App Engine
This is Rietveld 408576698