Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

Issue 1242613002: [Android] Supporting floating select ActionModes for web content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java
index 09fe942729befa079731ae132950e51baba0e352..5604a83b7b1f9f68c69863fb988e9c393b33bc6a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java
@@ -15,7 +15,6 @@ import android.os.Handler;
import android.os.Message;
import android.text.TextUtils;
import android.util.Pair;
-import android.view.ActionMode;
import android.view.ContextMenu;
import android.view.KeyEvent;
import android.view.View;
@@ -72,7 +71,7 @@ import org.chromium.content.browser.ActivityContentVideoViewClient;
import org.chromium.content.browser.ContentVideoViewClient;
import org.chromium.content.browser.ContentViewClient;
import org.chromium.content.browser.ContentViewCore;
-import org.chromium.content.browser.WebActionMode;
+import org.chromium.content.browser.WebActionModeCallback;
import org.chromium.content.browser.WebActionModeCallback.ActionHandler;
import org.chromium.content.browser.crypto.CipherFactory;
import org.chromium.content_public.browser.GestureStateListener;
@@ -761,18 +760,9 @@ public class ChromeTab extends Tab {
}
@Override
- public WebActionMode startActionMode(
- View view, ActionHandler actionHandler, boolean floating) {
- if (floating) return null;
- ChromeWebActionModeCallback callback =
- new ChromeWebActionModeCallback(view.getContext(), actionHandler);
- ActionMode actionMode = view.startActionMode(callback);
- return actionMode != null ? new WebActionMode(actionMode) : null;
- }
-
- @Override
- public boolean supportsFloatingActionMode() {
- return false;
+ public WebActionModeCallback getWebActionModeCallback(
+ Context context, ActionHandler actionHandler) {
+ return new ChromeWebActionModeCallback(context, actionHandler);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698