Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2638)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

Issue 1242613002: [Android] Supporting floating select ActionModes for web content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
index 153cc820ab4526c1e4fbcb43d5e34065f75baf4b..0108c8b518de749b7d65eb36fcf25828e83d9c6e 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
@@ -373,10 +373,19 @@ public abstract class AwContentsClient {
*/
public abstract void onNewPicture(Picture picture);
- public abstract WebActionMode startActionMode(
- View view, ActionHandler actionHandler, boolean floating);
+ /**
+ * TODO(jdduke): Remove when all embedders have been updated.
+ */
+ public WebActionMode startActionMode(View view, ActionHandler actionHandler, boolean floating) {
+ return null;
+ }
- public abstract boolean supportsFloatingActionMode();
+ /**
+ * TODO(jdduke): Remove when all embedders have been updated.
+ */
+ public boolean supportsFloatingActionMode() {
+ return false;
+ }
public void updateTitle(String title, boolean forceNotification) {
if (!forceNotification && TextUtils.equals(mTitle, title)) return;

Powered by Google App Engine
This is Rietveld 408576698