content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java - Issue 1242613002: [Android] Supporting floating select ActionModes for web content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java

Issue 1242613002: [Android] Supporting floating select ActionModes for web content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java ('K') | « content/public/android/java/src/org/chromium/content/browser/WebActionMode.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java

index 9221995c97d6964a116f1aff8fa89d122cfa6d27..de3c623d80d8ecbe6a2f2edb4d682cc186f112d1 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java

@@ -644,7 +644,7 @@ public class ContentViewCoreSelectionTest extends ContentShellTestBase {

assertTrue(CriteriaHelper.pollForUIThreadCriteria(new Criteria() {

@Override

public boolean isSatisfied() {

- return show == mContentViewCore.getPastePopupForTest().isShowing();

+ return show == mContentViewCore.isPastePopupShowingForTest();

}

}));

}