Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: cc/trees/layer_tree_host.cc

Issue 12426024: cc: Switch RenderingStats collection in Layer::Update() to RenderingStatsInstrumentation (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host.cc
diff --git a/cc/trees/layer_tree_host.cc b/cc/trees/layer_tree_host.cc
index ea17e79da787bd1c7ad8c4e38597270bd2d1af1e..2c670a06f2f9e205a55dbeebd2604bad37adb74e 100644
--- a/cc/trees/layer_tree_host.cc
+++ b/cc/trees/layer_tree_host.cc
@@ -810,8 +810,7 @@ size_t LayerTreeHost::CalculateMemoryForRenderSurfaces(
}
bool LayerTreeHost::PaintMasksForRenderSurface(Layer* render_surface_layer,
- ResourceUpdateQueue* queue,
- RenderingStats* stats) {
+ ResourceUpdateQueue* queue) {
// Note: Masks and replicas only exist for layers that own render surfaces. If
// we reach this point in code, we already know that at least something will
// be drawn into this render surface, so the mask and replica should be
@@ -820,7 +819,7 @@ bool LayerTreeHost::PaintMasksForRenderSurface(Layer* render_surface_layer,
bool need_more_updates = false;
Layer* mask_layer = render_surface_layer->mask_layer();
if (mask_layer) {
- mask_layer->Update(queue, NULL, stats);
+ mask_layer->Update(queue, NULL);
need_more_updates |= mask_layer->NeedMoreUpdates();
}
@@ -828,7 +827,7 @@ bool LayerTreeHost::PaintMasksForRenderSurface(Layer* render_surface_layer,
render_surface_layer->replica_layer() ?
render_surface_layer->replica_layer()->mask_layer() : NULL;
if (replica_mask_layer) {
- replica_mask_layer->Update(queue, NULL, stats);
+ replica_mask_layer->Update(queue, NULL);
need_more_updates |= replica_mask_layer->NeedMoreUpdates();
}
return need_more_updates;
@@ -856,11 +855,6 @@ bool LayerTreeHost::PaintLayerContents(
PrioritizeTextures(render_surface_layer_list,
occlusion_tracker.overdraw_metrics());
- // TODO(egraether): Use RenderingStatsInstrumentation in Layer::update()
- RenderingStats stats;
- RenderingStats* stats_ptr =
- debug_state_.RecordRenderingStats() ? &stats : NULL;
-
LayerIteratorType end = LayerIteratorType::End(&render_surface_layer_list);
for (LayerIteratorType it =
LayerIteratorType::Begin(&render_surface_layer_list);
@@ -871,18 +865,16 @@ bool LayerTreeHost::PaintLayerContents(
if (it.represents_target_render_surface()) {
DCHECK(it->render_surface()->draw_opacity() ||
it->render_surface()->draw_opacity_is_animating());
- need_more_updates |= PaintMasksForRenderSurface(*it, queue, stats_ptr);
+ need_more_updates |= PaintMasksForRenderSurface(*it, queue);
} else if (it.represents_itself()) {
DCHECK(!it->bounds().IsEmpty());
- it->Update(queue, &occlusion_tracker, stats_ptr);
+ it->Update(queue, &occlusion_tracker);
need_more_updates |= it->NeedMoreUpdates();
}
occlusion_tracker.LeaveLayer(it);
}
- rendering_stats_instrumentation_->AddStats(stats);
-
occlusion_tracker.overdraw_metrics()->RecordMetrics(this);
return need_more_updates;

Powered by Google App Engine
This is Rietveld 408576698