cc/layers/layer.cc - Issue 12426024: cc: Switch RenderingStats collection in Layer::Update() to RenderingStatsInstrumentation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/layers/layer.cc

Issue 12426024: cc: Switch RenderingStats collection in Layer::Update() to RenderingStatsInstrumentation (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase to 190697 Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2010 The Chromium Authors. All rights reserved.	1 // Copyright 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "cc/layers/layer.h"	5 #include "cc/layers/layer.h"

6	6

7 #include "base/metrics/histogram.h"	7 #include "base/metrics/histogram.h"

8 #include "cc/animation/animation.h"	8 #include "cc/animation/animation.h"

9 #include "cc/animation/animation_events.h"	9 #include "cc/animation/animation_events.h"

10 #include "cc/animation/layer_animation_controller.h"	10 #include "cc/animation/layer_animation_controller.h"

(...skipping 799 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
810 Region Layer::VisibleContentOpaqueRegion() const {	810 Region Layer::VisibleContentOpaqueRegion() const {

811 if (contents_opaque())	811 if (contents_opaque())

812 return visible_content_rect();	812 return visible_content_rect();

813 return Region();	813 return Region();

814 }	814 }

815	815

816 ScrollbarLayer* Layer::ToScrollbarLayer() {	816 ScrollbarLayer* Layer::ToScrollbarLayer() {

817 return NULL;	817 return NULL;

818 }	818 }

819	819

	820 RenderingStatsInstrumentation* Layer::rendering_stats_instrumentation() const {

	821 CHECK(layer_tree_host());
	danakj 2013/03/26 18:47:50 The check is kind of redundant. We'll crash on the The check is kind of redundant. We'll crash on the layer_tree_host() NULL deref anyways. And a null deref isn't accessing arbitrary memory, so I don't think you need the CHECK() here.
	822 return layer_tree_host()->rendering_stats_instrumentation();
	danakj 2013/03/26 18:47:50 nit: layer_tree_host_-> nit: layer_tree_host_->
	823 }

	824

820 } // namespace cc	825 } // namespace cc

OLD	NEW

« no previous file with comments | « cc/layers/layer.h ('k') | cc/layers/nine_patch_layer.h » ('j') | cc/resources/bitmap_content_layer_updater.cc » ('J')