Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 12426009: Revert 187669 "Adjust the profile sync service to properly set p..." (Closed)

Created:
7 years, 9 months ago by pastarmovj
Modified:
7 years, 9 months ago
Reviewers:
pastarmovj
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

Revert 187669 "Adjust the profile sync service to properly set p..." NOTE:Will recommit this one after we get session manager to change flags on ChromeOS. Adjust the profile sync service to properly set per user or per machine flags. Since flags are handled differntly on ChromeOS now the sync service needs to change the way it stores its flags until those are moved to proper prefs. BUG=chromium:181331 TEST=Sync service experiments should still work. > > > Review URL: https://chromiumcodereview.appspot.com/12549017 TBR=pastarmovj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187881

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -26 lines) Patch
M chrome/browser/sync/profile_sync_service.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 5 chunks +16 lines, -23 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pastarmovj
7 years, 9 months ago (2013-03-13 17:00:35 UTC) #1
pastarmovj
7 years, 9 months ago (2013-03-13 17:00:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r187881.

Powered by Google App Engine
This is Rietveld 408576698