Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Side by Side Diff: Source/core/layout/LayoutView.h

Issue 1242593004: Fix invalidity in HitTestCache with LayoutParts. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make clearHitTestCache recursive Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2006 Apple Computer, Inc. 3 * Copyright (C) 2006 Apple Computer, Inc.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 void willBeDestroyed() override; 53 void willBeDestroyed() override;
54 54
55 // hitTest() will update layout, style and compositing first while hitTestNo LifecycleUpdate() does not. 55 // hitTest() will update layout, style and compositing first while hitTestNo LifecycleUpdate() does not.
56 bool hitTest(HitTestResult&); 56 bool hitTest(HitTestResult&);
57 bool hitTestNoLifecycleUpdate(HitTestResult&); 57 bool hitTestNoLifecycleUpdate(HitTestResult&);
58 58
59 // Returns the total count of calls to HitTest, for testing. 59 // Returns the total count of calls to HitTest, for testing.
60 unsigned hitTestCount() const { return m_hitTestCount; } 60 unsigned hitTestCount() const { return m_hitTestCount; }
61 unsigned hitTestCacheHits() const { return m_hitTestCacheHits; } 61 unsigned hitTestCacheHits() const { return m_hitTestCacheHits; }
62 62
63 void clearHitTestCache() { m_hitTestCache->clear(); } 63 void clearHitTestCache();
64 64
65 const char* name() const override { return "LayoutView"; } 65 const char* name() const override { return "LayoutView"; }
66 66
67 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectLayoutView || LayoutBlockFlow::isOfType(type); } 67 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectLayoutView || LayoutBlockFlow::isOfType(type); }
68 68
69 DeprecatedPaintLayerType layerTypeRequired() const override { return NormalD eprecatedPaintLayer; } 69 DeprecatedPaintLayerType layerTypeRequired() const override { return NormalD eprecatedPaintLayer; }
70 70
71 bool isChildAllowed(LayoutObject*, const ComputedStyle&) const override; 71 bool isChildAllowed(LayoutObject*, const ComputedStyle&) const override;
72 72
73 void layout() override; 73 void layout() override;
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 m_paintInvalidationState->m_cachedOffsetsEnabled = true; 259 m_paintInvalidationState->m_cachedOffsetsEnabled = true;
260 } 260 }
261 private: 261 private:
262 const PaintInvalidationState* m_paintInvalidationState; 262 const PaintInvalidationState* m_paintInvalidationState;
263 bool m_didDisable; 263 bool m_didDisable;
264 }; 264 };
265 265
266 } // namespace blink 266 } // namespace blink
267 267
268 #endif // LayoutView_h 268 #endif // LayoutView_h
OLDNEW
« no previous file with comments | « LayoutTests/fast/events/hit-test-cache-iframes-expected.txt ('k') | Source/core/layout/LayoutView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698