Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 1242563003: Unittests don't use deprecated APIs. Yay! (Closed)

Created:
5 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Unittests don't use deprecated APIs. Yay! Make sure it stays that way BUG=v8:4134 R=yangguo@chromium.org LOG=n Committed: https://crrev.com/b8a49781104c5716a628dcbea6a77b14d2ec7dd7 Cr-Commit-Position: refs/heads/master@{#29741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M test/unittests/unittests.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 5 months ago (2015-07-17 12:47:13 UTC) #1
Yang
On 2015/07/17 12:47:13, jochen wrote: lgtm.
5 years, 5 months ago (2015-07-20 06:28:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242563003/1
5 years, 5 months ago (2015-07-20 06:29:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-20 06:54:58 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 06:55:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8a49781104c5716a628dcbea6a77b14d2ec7dd7
Cr-Commit-Position: refs/heads/master@{#29741}

Powered by Google App Engine
This is Rietveld 408576698