Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1729)

Unified Diff: Source/platform/drm/ContentDecryptionModuleSession.h

Issue 124253003: Update MediaKeySession events to match latest EME spec (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/drm/ContentDecryptionModuleSession.h
diff --git a/Source/platform/drm/ContentDecryptionModuleSession.h b/Source/platform/drm/ContentDecryptionModuleSession.h
index ef58745ab67e209642806d420102fb4eb3dd73e7..ee1154f6bcf026cacd308c56a9289c9f5ba67ab4 100644
--- a/Source/platform/drm/ContentDecryptionModuleSession.h
+++ b/Source/platform/drm/ContentDecryptionModuleSession.h
@@ -52,9 +52,10 @@ class KURL;
class PLATFORM_EXPORT ContentDecryptionModuleSessionClient {
public:
enum MediaKeyErrorCode { UnknownError = 1, ClientError };
- virtual void keyAdded() = 0;
virtual void keyError(MediaKeyErrorCode, unsigned long systemCode) = 0;
xhwang 2014/01/03 23:38:20 Here and everywhere, we should drop the "Key" part
ddorwin 2014/01/07 23:44:41 +1
jrummell 2014/01/08 18:05:52 Done. I couldn't find any examples of Onxxx anywhe
virtual void keyMessage(const unsigned char* message, size_t messageLength, const KURL& destinationURL) = 0;
+ virtual void keyReady() = 0;
ddorwin 2014/01/07 23:44:41 These had been in alphabetical order. The Chromium
jrummell 2014/01/08 18:05:52 Prefer lifecycle order, so moved Error() to end of
+ virtual void keyClosed() = 0;
};
class PLATFORM_EXPORT ContentDecryptionModuleSession : private blink::WebContentDecryptionModuleSession::Client {
@@ -72,9 +73,10 @@ public:
private:
// blink::WebContentDecryptionModuleSession::Client
- virtual void keyAdded() OVERRIDE;
virtual void keyError(MediaKeyErrorCode, unsigned long systemCode) OVERRIDE;
virtual void keyMessage(const unsigned char* message, size_t messageLength, const blink::WebURL& destinationURL) OVERRIDE;
+ virtual void keyReady() OVERRIDE;
+ virtual void keyClosed() OVERRIDE;
OwnPtr<blink::WebContentDecryptionModuleSession> m_session;

Powered by Google App Engine
This is Rietveld 408576698