add unittest for render_pictures binary

add unittest for render_pictures binary

Once committed, this will be run as part of RunToolSelfTests on http://108.170.217.252:10117/builders/Housekeeper-PerCommit .

BUG=skia:1943
Committed: http://code.google.com/p/skia/source/detail?r=12941

[epoger, 2014-01-03 21:46:12]

Ready for review at patchset 1.

https://codereview.chromium.org/124253002/diff/1/tools/tests/base_unittest.py
File tools/tests/base_unittest.py (right):

https://codereview.chromium.org/124253002/diff/1/tools/tests/base_unittest.py...
tools/tests/base_unittest.py:41: def find_path_to_program(self, program):
I copied this function over from tools/test_rendering.py .  As I have noted
within that file, at some point the two files should be combined.

https://codereview.chromium.org/124253002/diff/1/tools/tests/render_pictures_...
File tools/tests/render_pictures_test.py (right):

https://codereview.chromium.org/124253002/diff/1/tools/tests/render_pictures_...
tools/tests/render_pictures_test.py:49: "input.png" : [ "bitmap-64bitMD5",
12793741875005523433 ]
I have not validated that this checksum is actually correct for the SKP we are
rendering (a 640x400 red rectangle).  But if we do a spot check of the
render_pictures output, and the unittest results remain consistent over time,
that should keep our tools in working order.

https://codereview.chromium.org/124253002/diff/1/tools/tests/render_pictures_...
tools/tests/render_pictures_test.py:58: TODO(epoger): The results of this test
are currently broken!
I was surprised to see the results of this test!  Definitely worth more
investigation, but I'd like to get the unittests checked in as soon as possible
anyway.

[epoger, 2014-01-03 21:46:51]

[CCing Eric, just for the heck of it]

[rmistry, 2014-01-06 18:54:43]

https://codereview.chromium.org/124253002/diff/1/tools/tests/render_pictures_...
File tools/tests/render_pictures_test.py (right):

https://codereview.chromium.org/124253002/diff/1/tools/tests/render_pictures_...
tools/tests/render_pictures_test.py:28: # Setup and teardown...
Do not need this comment.

https://codereview.chromium.org/124253002/diff/1/tools/tests/render_pictures_...
tools/tests/render_pictures_test.py:36: # Individual test cases...
Do not need this comment since it is obvious from the names test_*

https://codereview.chromium.org/124253002/diff/1/tools/tests/render_pictures_...
tools/tests/render_pictures_test.py:73: # Helper functions...
Do not need this comment as well.

https://codereview.chromium.org/124253002/diff/1/tools/tests/render_pictures_...
tools/tests/render_pictures_test.py:81: '--mode', 'tile', '256', '256',
It might also be worth doing a test with render_pictures args without '--bbh
grid 256 256' and '--mode tile 256 256' i.e. whole image test without
--writeWholeImage. WDYT?

[epoger, 2014-01-06 20:46:13]

https://codereview.chromium.org/124253002/diff/1/tools/tests/render_pictures_...
File tools/tests/render_pictures_test.py (right):

https://codereview.chromium.org/124253002/diff/1/tools/tests/render_pictures_...
tools/tests/render_pictures_test.py:28: # Setup and teardown...
On 2014/01/06 18:54:44, rmistry wrote:
> Do not need this comment.

Removed.  I like having the sections delineated, but I guess tastes vary.

https://codereview.chromium.org/124253002/diff/1/tools/tests/render_pictures_...
tools/tests/render_pictures_test.py:36: # Individual test cases...
On 2014/01/06 18:54:44, rmistry wrote:
> Do not need this comment since it is obvious from the names test_*

Done.

https://codereview.chromium.org/124253002/diff/1/tools/tests/render_pictures_...
tools/tests/render_pictures_test.py:73: # Helper functions...
On 2014/01/06 18:54:44, rmistry wrote:
> Do not need this comment as well.

Done.

https://codereview.chromium.org/124253002/diff/1/tools/tests/render_pictures_...
tools/tests/render_pictures_test.py:81: '--mode', 'tile', '256', '256',
On 2014/01/06 18:54:44, rmistry wrote:
> It might also be worth doing a test with render_pictures args without '--bbh
> grid 256 256' and '--mode tile 256 256' i.e. whole image test without
> --writeWholeImage. WDYT?

Sure, good idea.  Note that it gives unexpected results, too, which I will
address as soon as this CL lands.

https://codereview.chromium.org/124253002/diff/80001/tools/tests/base_unittes...
File tools/tests/base_unittest.py (right):

https://codereview.chromium.org/124253002/diff/80001/tools/tests/base_unittes...
tools/tests/base_unittest.py:20: def shortDescription(self):
Added this because it makes the output more readable.

[rmistry, 2014-01-06 21:01:17]

LGTM

[commit-bot: I haz the power, 2014-01-07 16:12:07]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/epoger@google.com/124253002/160001

[commit-bot: I haz the power, 2014-01-07 17:03:44]

Change committed as 12941