Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1242453003: Extract the shell runner into devtools. (Closed)

Created:
5 years, 5 months ago by ppi
Modified:
5 years, 5 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Extract the shell runner into devtools. In this patch, mojo/tools/mojo_shell.py is moved to devtools. Default output paths corresponding to a regular Mojo checkout are inferred, so that it continues to work out-of-the-box there. In the next step we will make it easier (in particular, possible) to use the runner outside of the regular Mojo checkout too (allow to indicate some paths by hand, allow to run against already installed device Mojo Shell, etc.) R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/524585020ad434dc3b11004f3baa178a310cbf43

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Address Ben's comments. #

Patch Set 4 : Update more paths and devtools README. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -215 lines) Patch
M README.md View 1 2 3 4 chunks +11 lines, -19 lines 0 comments Download
M examples/dart/camera_roll/camera_roll.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M examples/dart/speech_input/speech_input.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M examples/go/README.txt View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M examples/java_android/echo/src/org/chromium/examples/java_echo/README.md View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/devtools/common/README.md View 1 2 3 2 chunks +18 lines, -20 lines 0 comments Download
A mojo/devtools/common/devtoolslib/default_paths.py View 1 2 1 chunk +58 lines, -0 lines 0 comments Download
A + mojo/devtools/common/mojo_shell View 1 2 3 3 chunks +15 lines, -24 lines 0 comments Download
M mojo/tools/mojo_shell.py View 1 chunk +6 lines, -144 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ppi
Hi Ben, ptal.
5 years, 5 months ago (2015-07-16 14:12:18 UTC) #2
qsr
https://codereview.chromium.org/1242453003/diff/20001/mojo/devtools/common/devtoolslib/default_paths.py File mojo/devtools/common/devtoolslib/default_paths.py (right): https://codereview.chromium.org/1242453003/diff/20001/mojo/devtools/common/devtoolslib/default_paths.py#newcode58 mojo/devtools/common/devtoolslib/default_paths.py:58: return paths, '' According to your doc, this should ...
5 years, 5 months ago (2015-07-16 14:19:20 UTC) #3
ppi
https://codereview.chromium.org/1242453003/diff/20001/mojo/devtools/common/devtoolslib/default_paths.py File mojo/devtools/common/devtoolslib/default_paths.py (right): https://codereview.chromium.org/1242453003/diff/20001/mojo/devtools/common/devtoolslib/default_paths.py#newcode58 mojo/devtools/common/devtoolslib/default_paths.py:58: return paths, '' On 2015/07/16 14:19:20, qsr wrote: > ...
5 years, 5 months ago (2015-07-16 14:23:45 UTC) #4
qsr
lgtm
5 years, 5 months ago (2015-07-16 14:25:49 UTC) #5
ppi
5 years, 5 months ago (2015-07-16 14:52:05 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
524585020ad434dc3b11004f3baa178a310cbf43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698