Issue 1242453002: Update sky HACKING.md instructions to use mojo_shell.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1242453002: Update sky HACKING.md instructions to use mojo_shell.py. (Closed)

Created:
5 years, 5 months ago by ppi

Modified:
5 years, 5 months ago

Reviewers:
abarth-chromium, Hixie

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Update sky HACKING.md instructions to use mojo_shell.py. See #238. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d0afc5f9d10f5f9e38f851d5b290421710869272

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Update the paths after mojo_shell.py move. #

Total comments: 1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -24 lines)			Patch
	M	sky/HACKING.md	View	1 2	2 chunks	+19 lines, -24 lines	1 comment	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ppi

Committed patchset #3 (id:40001) manually as d0afc5f9d10f5f9e38f851d5b290421710869272 (presubmit successful).

5 years, 5 months ago (2015-07-16 15:08:20 UTC) #4

Hixie

5 years, 5 months ago (2015-07-16 15:40:40 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/1242453002/diff/40001/sky/HACKING.md
File sky/HACKING.md (left):

https://codereview.chromium.org/1242453002/diff/40001/sky/HACKING.md#oldcode82
sky/HACKING.md:82: will load (slowly), after spawning many threads. When your
app
Is it no longer slow? That's great news if so!

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages