Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 1242383005: Remove unused code in ConfirmBubbleModel (Closed)

Created:
5 years, 5 months ago by Evan Stade
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused code in ConfirmBubbleModel BUG=none Committed: https://crrev.com/f04566dc24e1afdd011ad8b04ca4c7c0b03908bb Cr-Commit-Position: refs/heads/master@{#341205}

Patch Set 1 #

Patch Set 2 : update mac #

Patch Set 3 : mac compile #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -48 lines) Patch
M chrome/browser/renderer_context_menu/spelling_bubble_model.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/spelling_bubble_model.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_cocoa.mm View 1 2 3 chunks +1 line, -14 lines 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_controller.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_controller.mm View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/confirm_bubble_model.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/test/test_confirm_bubble_model.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/test/test_confirm_bubble_model.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 22 (7 generated)
Evan Stade
5 years, 5 months ago (2015-07-23 21:22:07 UTC) #2
Nico
lgtm
5 years, 5 months ago (2015-07-23 21:22:48 UTC) #3
please use gerrit instead
lgtm
5 years, 5 months ago (2015-07-23 21:26:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242383005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1242383005/1
5 years, 5 months ago (2015-07-23 21:30:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/90781)
5 years, 5 months ago (2015-07-23 21:53:25 UTC) #8
Evan Stade
ok, so it appears mac still uses the icon. Should it? It was removed from ...
5 years, 5 months ago (2015-07-23 22:56:23 UTC) #10
Evan Stade
On 2015/07/23 22:56:23, Evan Stade wrote: > ok, so it appears mac still uses the ...
5 years, 4 months ago (2015-07-27 16:00:50 UTC) #11
Evan Stade
OK Rouslan, maybe you can answer the above question since you're the spellcheck maintainer.
5 years, 4 months ago (2015-07-28 16:41:50 UTC) #12
please use gerrit instead
On 2015/07/23 22:56:23, Evan Stade wrote: > mac still uses the icon. Should it? Mac ...
5 years, 4 months ago (2015-07-28 17:20:36 UTC) #13
msw
On 2015/07/27 16:00:50, Evan Stade wrote: > On 2015/07/23 22:56:23, Evan Stade wrote: > > ...
5 years, 4 months ago (2015-07-28 19:52:16 UTC) #14
Evan Stade
+groby for review of cocoa/ (only deletions)
5 years, 4 months ago (2015-07-30 01:43:05 UTC) #16
groby-ooo-7-16
c/b/ui/cocoa lgtm
5 years, 4 months ago (2015-07-30 20:52:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242383005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1242383005/60001
5 years, 4 months ago (2015-07-30 21:59:41 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-07-30 22:17:34 UTC) #21
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 22:18:25 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f04566dc24e1afdd011ad8b04ca4c7c0b03908bb
Cr-Commit-Position: refs/heads/master@{#341205}

Powered by Google App Engine
This is Rietveld 408576698