Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4119)

Unified Diff: chrome/browser/PRESUBMIT.py

Issue 1242383003: Split web_dev_style tests into separate files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/test_presubmit.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/PRESUBMIT.py
diff --git a/chrome/browser/PRESUBMIT.py b/chrome/browser/PRESUBMIT.py
index 7230324123f8c5147b8dd7966d8defe7293516d6..143ff1c09d4c2afa15f49928a9084cb084195e75 100644
--- a/chrome/browser/PRESUBMIT.py
+++ b/chrome/browser/PRESUBMIT.py
@@ -31,13 +31,13 @@ def _CommonChecks(input_api, output_api):
webui = path.join(cwd, 'ui', 'webui')
affected_files = (f.AbsoluteLocalPath() for f in input_api.AffectedFiles())
- would_affect_tests = (
+
+ would_affect_tests = [
path.join(cwd, 'PRESUBMIT.py'),
path.join(cwd, 'test_presubmit.py'),
- path.join(cwd, 'web_dev_style', 'css_checker.py'),
- path.join(cwd, 'web_dev_style', 'html_checker.py'),
- path.join(cwd, 'web_dev_style', 'js_checker.py'),
- )
+ ]
+ would_affect_tests += input_api.glob(path.join(cwd, 'web_dev_style', '*.py'))
+
if any(f for f in affected_files if f in would_affect_tests):
tests = [path.join(cwd, 'test_presubmit.py')]
results.extend(
« no previous file with comments | « no previous file | chrome/browser/test_presubmit.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698