Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: src/frames.cc

Issue 1242333002: Reland concurrent sweeping of code space. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.cc
diff --git a/src/frames.cc b/src/frames.cc
index 5f51dec2882cab9c473032d47c15bfce5d711105..0a5138eb7ae53e37a7bd1ce3e14912699020508a 100644
--- a/src/frames.cc
+++ b/src/frames.cc
@@ -1446,6 +1446,10 @@ Code* InnerPointerToCodeCache::GcSafeFindCodeForInnerPointer(
// after the inner pointer.
Page* page = Page::FromAddress(inner_pointer);
+ DCHECK(page->owner() == heap->code_space());
jochen (gone - plz use gerrit) 2015/07/27 14:53:05 DCHECK_EQ?
Hannes Payer (out of office) 2015/07/27 15:04:45 Done.
+ heap->mark_compact_collector()->SweepOrWaitUntilSweepingCompleted(
+ page, reinterpret_cast<PagedSpace*>(page->owner()));
jochen (gone - plz use gerrit) 2015/07/27 14:53:05 you always invoke this method with page, page->own
Hannes Payer (out of office) 2015/07/27 15:04:45 Done.
+
Address addr = page->skip_list()->StartFor(inner_pointer);
Address top = heap->code_space()->top();
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698