Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1242333002: Reland concurrent sweeping of code space. (Closed)

Created:
5 years, 5 months ago by Hannes Payer (out of office)
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland concurrent sweeping of code space. BUG= Committed: https://crrev.com/8516dccf6a561020441773c93c564dd4aa6ee59e Cr-Commit-Position: refs/heads/master@{#29967}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 4

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -38 lines) Patch
M src/frames.cc View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M src/heap/mark-compact.h View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 4 5 11 chunks +77 lines, -28 lines 0 comments Download
M src/heap/spaces.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/store-buffer.cc View 1 2 3 4 5 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-20 15:24:51 UTC) #2
jochen (gone - plz use gerrit)
still lgtm https://codereview.chromium.org/1242333002/diff/80001/src/frames.cc File src/frames.cc (right): https://codereview.chromium.org/1242333002/diff/80001/src/frames.cc#newcode1449 src/frames.cc:1449: DCHECK(page->owner() == heap->code_space()); DCHECK_EQ? https://codereview.chromium.org/1242333002/diff/80001/src/frames.cc#newcode1451 src/frames.cc:1451: page, ...
5 years, 4 months ago (2015-07-27 14:53:05 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/1242333002/diff/80001/src/frames.cc File src/frames.cc (right): https://codereview.chromium.org/1242333002/diff/80001/src/frames.cc#newcode1449 src/frames.cc:1449: DCHECK(page->owner() == heap->code_space()); On 2015/07/27 14:53:05, jochen wrote: > ...
5 years, 4 months ago (2015-07-27 15:04:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242333002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1242333002/100001
5 years, 4 months ago (2015-08-03 08:39:42 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 4 months ago (2015-08-03 09:15:31 UTC) #8
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/8516dccf6a561020441773c93c564dd4aa6ee59e Cr-Commit-Position: refs/heads/master@{#29967}
5 years, 4 months ago (2015-08-03 09:15:54 UTC) #9
Hannes Payer (out of office)
5 years, 4 months ago (2015-08-03 13:06:30 UTC) #10
Message was sent while issue was closed. 
A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1263343002/ by hpayer@chromium.org.

The reason for reverting is: Reverted because 507840 came back on recent
Chromecrash. Should not have committed this Cl..

Powered by Google App Engine
This is Rietveld 408576698