Chromium Code Reviews| Index: Source/platform/graphics/BitmapImage.h |
| diff --git a/Source/platform/graphics/BitmapImage.h b/Source/platform/graphics/BitmapImage.h |
| index 6d49ff74f2bb1670bab47930ca08a0bb50066e70..59a47baa83ddce259dce36c57e988bd508eb5e9b 100644 |
| --- a/Source/platform/graphics/BitmapImage.h |
| +++ b/Source/platform/graphics/BitmapImage.h |
| @@ -41,6 +41,23 @@ |
| namespace blink { |
| +enum DecodedImageType { |
| + // These values are histogrammed over time; do not change their ordinal |
|
Noel Gordon
2015/08/01 02:33:06
We should move this into its own file, similar to
urvang
2015/08/04 20:21:17
Can you explain why this is necessary?
- Other enu
|
| + // values. When deleting an image type, replace it with a dummy value; |
| + // when adding an image type, do so at the bottom (and update DecodedImageTypeMax). |
| + // Also, this enum should be in sync with the 'DecodedImageType' enum in |
| + // tools/metrics/histograms/histograms.xml |
|
Noel Gordon
2015/08/01 02:33:06
tools/metrics/histograms/histograms.xml -> src/too
urvang
2015/08/04 20:21:16
In code search, "tools/metrics/histograms/histogra
|
| + ImageUnknown = 0, |
| + ImageJPEG, |
| + ImagePNG, |
| + ImageGIF, |
| + ImageWebP, |
| + ImageICO, |
| + ImageBMP, |
| + |
| + DecodedImageTypeMax = ImageBMP // Must equal the last "real" image type above. |
|
Noel Gordon
2015/08/01 02:33:06
nit: abbv DecodedImageTypeMax. Rename it to LastD
urvang
2015/08/04 20:21:16
Done.
|
| +}; |
| + |
| template <typename T> class Timer; |
| class PLATFORM_EXPORT BitmapImage final : public Image { |