Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 1242253002: Refactor the treatment of shape-outside objects in float overlapping checks (Closed)

Created:
5 years, 5 months ago by rhogan
Modified:
5 years, 3 months ago
Reviewers:
Xianzhu, wangxianzhu
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactor the treatment of shape-outside objects in float overlapping checks Integrate shape-outside into the red-black tree used for checking whether an object overlaps with a float. This merges WebKit CL http://trac.webkit.org/changeset/158954 BUG=510872 Committed: https://crrev.com/41ea1fa678658ce3bcb3d9b1f52575c84511432e git-svn-id: svn://svn.chromium.org/blink/trunk@199519 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -55 lines) Patch
M Source/core/layout/FloatingObjects.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/layout/FloatingObjects.cpp View 8 chunks +95 lines, -29 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/layout/LayoutBlockFlow.cpp View 2 chunks +9 lines, -19 lines 0 comments Download
M Source/core/layout/api/LineLayoutBlockFlow.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/line/LineWidth.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
rhogan
5 years, 5 months ago (2015-07-21 10:06:40 UTC) #2
rhogan
Hi wangxianzhu - got time to take a look?
5 years, 5 months ago (2015-07-22 19:01:05 UTC) #3
Xianzhu
lgtm
5 years, 4 months ago (2015-07-27 16:41:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1242253002/1
5 years, 4 months ago (2015-07-27 16:41:32 UTC) #7
Peter Beverloo
Can we please have a much better description for this CL?
5 years, 4 months ago (2015-07-27 16:42:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1242253002/1
5 years, 4 months ago (2015-07-27 17:52:38 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199519
5 years, 4 months ago (2015-07-27 17:55:25 UTC) #12
dtu
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1263923002/ by dtu@chromium.org. ...
5 years, 4 months ago (2015-07-30 00:06:48 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:48:53 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41ea1fa678658ce3bcb3d9b1f52575c84511432e

Powered by Google App Engine
This is Rietveld 408576698