Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1242123002: Fix GetOwnPropertyNames on access-checked objects (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix GetOwnPropertyNames on access-checked objects BUG=chromium:509936 LOG=y Committed: https://crrev.com/76b3b21cdcbe4ae3a85b9577b6f5a52718cfcbd5 Cr-Commit-Position: refs/heads/master@{#29725}

Patch Set 1 #

Patch Set 2 : Handle empty case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -135 lines) Patch
M src/objects.h View 3 chunks +9 lines, -9 lines 0 comments Download
M src/objects.cc View 12 chunks +20 lines, -37 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 3 chunks +58 lines, -84 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-17 10:48:51 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-17 10:49:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242123002/1
5 years, 5 months ago (2015-07-17 10:59:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/7765) (exceeded global retry quota)
5 years, 5 months ago (2015-07-17 11:11:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242123002/20001
5 years, 5 months ago (2015-07-17 12:28:15 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-17 12:30:10 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 12:30:28 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76b3b21cdcbe4ae3a85b9577b6f5a52718cfcbd5
Cr-Commit-Position: refs/heads/master@{#29725}

Powered by Google App Engine
This is Rietveld 408576698