Issue 12421010: Try to fix Windows build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12421010: Try to fix Windows build (Closed)

Created:
7 years, 9 months ago by borenet

Modified:
7 years, 9 months ago

Reviewers:
edisonn, epoger

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix Windows build - revert r8056 and r8057 TBR=epoger,edisonn Committed: https://code.google.com/p/skia/source/detail?r=8058

Patch Set 1 #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -8 lines)			Patch
	M	gyp/tools.gyp	View		4 chunks	+4 lines, -4 lines	0 comments	Download
	M	tools/win_dbghelp.cpp	View		3 chunks	+1 line, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

borenet

Submitting unreviewed to get the bots green. Justifying with try results: http://70.32.156.53:10115/builders/Skia_Shuttle_Win7_Intel_Float_Debug_32_Trybot/builds/42 https://codereview.chromium.org/12421010/diff/1/tools/win_dbghelp.cpp File tools/win_dbghelp.cpp ...

7 years, 9 months ago (2013-03-08 23:13:21 UTC) #1

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages