Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 1242093002: Fix getPrototypeOf for access checked objects (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix getPrototypeOf for access checked objects BUG=chromium:509936 LOG=y Committed: https://crrev.com/dc71c1b5864466ca2d9943af169392b1e2a834b3 Cr-Commit-Position: refs/heads/master@{#29721}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Return null rather than undefined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -15 lines) Patch
M src/runtime/runtime-object.cc View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 2 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-17 08:00:46 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-17 08:06:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242093002/50001
5 years, 5 months ago (2015-07-17 09:00:56 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:50001)
5 years, 5 months ago (2015-07-17 09:37:33 UTC) #6
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/dc71c1b5864466ca2d9943af169392b1e2a834b3 Cr-Commit-Position: refs/heads/master@{#29721}
5 years, 5 months ago (2015-07-17 09:37:44 UTC) #7
Michael Achenbach
On 2015/07/17 09:37:44, commit-bot: I haz the power wrote: > Patchset 4 (id:??) landed as ...
5 years, 5 months ago (2015-07-17 10:58:14 UTC) #8
Michael Achenbach
5 years, 5 months ago (2015-07-17 10:59:27 UTC) #9
Message was sent while issue was closed.
On 2015/07/17 10:58:14, Michael Achenbach wrote:
> On 2015/07/17 09:37:44, commit-bot: I haz the power wrote:
> > Patchset 4 (id:??) landed as
> > https://crrev.com/dc71c1b5864466ca2d9943af169392b1e2a834b3
> > Cr-Commit-Position: refs/heads/master@{#29721}
> 
> This changes layout test expectations. Please fix blink upstream.

Note, some expectation lines change from PASS to FAIL.

Powered by Google App Engine
This is Rietveld 408576698