Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: go/src/infra/gae/libs/gae/memory/raw_datstore_test.go

Issue 1242043005: Improve memory implementation of gae to provide the full RawDatastore interface. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@port_broken_features
Patch Set: further simplification of CL Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: go/src/infra/gae/libs/gae/memory/raw_datstore_test.go
diff --git a/go/src/infra/gae/libs/gae/memory/raw_datstore_test.go b/go/src/infra/gae/libs/gae/memory/raw_datstore_test.go
index 620f0a61bbd55969b4c79117a28ae6f3fa5bc63b..8f75b9f052df0869e9bf43d7738363aaf15bdc28 100644
--- a/go/src/infra/gae/libs/gae/memory/raw_datstore_test.go
+++ b/go/src/infra/gae/libs/gae/memory/raw_datstore_test.go
@@ -109,15 +109,19 @@ func TestDatastoreSingleReadWriter(t *testing.T) {
So(err, ShouldBeNil)
})
- Convey("check that metadata works", func() {
+ Convey("with multiple puts", func() {
So(testGetMeta(c, k), ShouldEqual, 1)
+ keys := []gae.DSKey{}
+ plss := []gae.DSPropertyLoadSaver{}
+
pkey := k
for i := 0; i < 10; i++ {
- k := rds.NewKey("Foo", "", 0, pkey)
- _, err = rds.Put(k, pls(&Foo{Val: 10}))
- So(err, ShouldBeNil)
+ keys = append(keys, rds.NewKey("Foo", "", 0, pkey))
+ plss = append(plss, pls(&Foo{Val: 10}))
}
+ keys, err := rds.PutMulti(keys, plss)
+ So(err, ShouldBeNil)
So(testGetMeta(c, k), ShouldEqual, 11)
Convey("ensure that group versions persist across deletes", func() {
@@ -133,14 +137,26 @@ func TestDatastoreSingleReadWriter(t *testing.T) {
// /Foo,1/__entity_group_ids__,1
So(num, ShouldEqual, 3)
- version, err := curVersion(ents, groupMetaKey(k))
- So(err, ShouldBeNil)
- So(version, ShouldEqual, 22)
+ So(curVersion(ents, groupMetaKey(k)), ShouldEqual, 22)
k, err := rds.Put(k, pls(f))
So(err, ShouldBeNil)
So(testGetMeta(c, k), ShouldEqual, 23)
})
+
+ Convey("can GetMulti", func() {
+ plss := make([]gae.DSPropertyLoadSaver, len(keys))
+ for i := range plss {
+ plss[i] = gae.DSPropertyMap{}
+ }
+ err := rds.GetMulti(keys, plss)
+ So(err, ShouldBeNil)
+ for _, pls := range plss {
+ So(pls.(gae.DSPropertyMap), ShouldResemble, gae.DSPropertyMap{
+ "Val": {gae.MkDSProperty(10)},
+ })
+ }
+ })
})
})
})

Powered by Google App Engine
This is Rietveld 408576698