Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: go/src/infra/gae/libs/gae/memory/plist_test.go

Issue 1242043005: Improve memory implementation of gae to provide the full RawDatastore interface. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@port_broken_features
Patch Set: further simplification of CL Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « go/src/infra/gae/libs/gae/memory/plist.go ('k') | go/src/infra/gae/libs/gae/memory/raw_datstore.go » ('j') | go/src/infra/gae/libs/gae/memory/raw_datstore_data.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: go/src/infra/gae/libs/gae/memory/plist_test.go
diff --git a/go/src/infra/gae/libs/gae/memory/plist_test.go b/go/src/infra/gae/libs/gae/memory/plist_test.go
index 050919a457a65dba2401399465b8062628728d4a..9fffc8550dfdd0a40872efaaefd65ad763807be4 100644
--- a/go/src/infra/gae/libs/gae/memory/plist_test.go
+++ b/go/src/infra/gae/libs/gae/memory/plist_test.go
@@ -369,8 +369,7 @@ func TestUpdateIndicies(t *testing.T) {
for _, itm := range tc.data {
ks := itm.key.String()
prev := tmpLoader[ks]
- err := updateIndicies(store, itm.key, prev, itm.props)
- So(err, ShouldBeNil)
+ updateIndicies(store, itm.key, prev, itm.props)
tmpLoader[ks] = itm.props
}
tmpLoader = nil
« no previous file with comments | « go/src/infra/gae/libs/gae/memory/plist.go ('k') | go/src/infra/gae/libs/gae/memory/raw_datstore.go » ('j') | go/src/infra/gae/libs/gae/memory/raw_datstore_data.go » ('J')

Powered by Google App Engine
This is Rietveld 408576698