go/src/infra/gae/libs/gae/memory/gkvlite_utils.go - Issue 1242043005: Improve memory implementation of gae to provide the full RawDatastore interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: go/src/infra/gae/libs/gae/memory/gkvlite_utils.go

Issue 1242043005: Improve memory implementation of gae to provide the full RawDatastore interface. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@port_broken_features

Patch Set: further simplification of CL Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « go/src/infra/gae/libs/gae/memory/datastore_query.go ('k') | go/src/infra/gae/libs/gae/memory/plist.go » ('j') | go/src/infra/gae/libs/gae/memory/raw_datstore_data.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: go/src/infra/gae/libs/gae/memory/gkvlite_utils.go

diff --git a/go/src/infra/gae/libs/gae/memory/gkvlite_utils.go b/go/src/infra/gae/libs/gae/memory/gkvlite_utils.go

index 08b2b9b075ecfd5b73c37922d59e293cfb300d83..ac64f9b7d7905f1233459120d4231e7e3671b309 100644

--- a/go/src/infra/gae/libs/gae/memory/gkvlite_utils.go

+++ b/go/src/infra/gae/libs/gae/memory/gkvlite_utils.go

@@ -95,14 +95,6 @@ func (ms *memStore) SetCollection(name string, cmp gkvlite.KeyCompare) *memColle

return (*memCollection)((*gkvlite.Store)(ms).SetCollection(name, cmp))

}

-func (ms *memStore) RemoveCollection(name string) {

- (*gkvlite.Store)(ms).RemoveCollection(name)

-func (ms *memStore) GetCollectionNames() []string {

- return (*gkvlite.Store)(ms).GetCollectionNames()

// memCollection is a gkvlite.Collection which will panic for anything which

// might otherwise return an error.