Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: sdk/lib/async/broadcast_stream_controller.dart

Issue 1242023007: Add setters for callbacks on StreamController. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/async/broadcast_stream_controller.dart
diff --git a/sdk/lib/async/broadcast_stream_controller.dart b/sdk/lib/async/broadcast_stream_controller.dart
index 93c0833317c26f2393dd14fb46aea127ca1edf4b..e5a1efc777d0e212c2ea3ae37b2622d024f5a071 100644
--- a/sdk/lib/async/broadcast_stream_controller.dart
+++ b/sdk/lib/async/broadcast_stream_controller.dart
@@ -67,7 +67,6 @@ class _BroadcastSubscription<T> extends _ControllerSubscription<T>
// _onCancel is inherited.
}
-
abstract class _BroadcastStreamController<T>
implements StreamController<T>,
_StreamControllerLifecycle<T>,
@@ -80,8 +79,8 @@ abstract class _BroadcastStreamController<T>
static const int _STATE_CLOSED = 4;
static const int _STATE_ADDSTREAM = 8;
- final _NotificationHandler _onListen;
- final _NotificationHandler _onCancel;
+ _NotificationHandler _onListen;
+ _NotificationHandler _onCancel;
// State of the controller.
int _state;
@@ -113,6 +112,20 @@ abstract class _BroadcastStreamController<T>
_next = _previous = this;
}
+ void set onListen(void onListenHandler()) { _onListen = onListenHandler; }
+
+ void set onPause(void onPauseHandler()) {
+ throw new UnsupportedError(
+ "Broadcast stream controllers do not support pause callbacks");
+ }
+
+ void set onResume(void onResumeHandler()) {
+ throw new UnsupportedError(
+ "Broadcast stream controllers do not support pause callbacks");
+ }
+
+ void set onCancel(onCancelHandler()) { _onCancel = onCancelHandler; }
+
// StreamController interface.
Stream<T> get stream => new _BroadcastStream<T>(this);

Powered by Google App Engine
This is Rietveld 408576698