Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: tools/llvm_coverage_run.py

Issue 1242023002: Coverage script: fix missing data (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/llvm_coverage_run.py
diff --git a/tools/llvm_coverage_run.py b/tools/llvm_coverage_run.py
index 00641ca61af1fa17f8ac01a5f4893b1de5143371..e0d0ff6f5a6cc00bc78f2844cb9f46d3b3e49d1d 100755
--- a/tools/llvm_coverage_run.py
+++ b/tools/llvm_coverage_run.py
@@ -162,6 +162,14 @@ def main():
'--properties', metavar='key_or_value', nargs='+',
help='key/value pairs representing properties of this build.')
args, cmd = parser.parse_known_args()
+
+ # We still need to pass the args we stripped out to DM.
+ cmd.append('--key')
+ cmd.extend(args.key)
+ cmd.append('--properties')
+ cmd.extend(args.properties)
+
+ # Parse the key and properties for use in the nanobench JSON output.
key = _parse_key_value(args.key)
properties = _parse_key_value(args.properties)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698