Restore depot_tools autoupdate in Windows.

Restore depot_tools autoupdate in Windows.

Executing a bat file from another bat file will replace
that first bat file with the second one. To call the
second one and then return and execute the rest of the
first one, you have to do "call second.bat"

"python" is really "python.bat" so that this happened
was not obvious. More obvious now.

BUG=511926
R=sergiyb@chromium.org

[Daniel Bratell, 2015-07-20 08:49:46]

To get depot_tools update working again.

[Sergiy Byelozyorov, 2015-07-20 08:57:18]

Thanks a lot of for fixing this. I was not aware Windows users didn't have their
depot_tools updated since my CL and just hope that depot_tools will still work
for them after the update actually happens.

https://codereview.chromium.org/1242013003/diff/1/update_depot_tools.bat
File update_depot_tools.bat (left):

https://codereview.chromium.org/1242013003/diff/1/update_depot_tools.bat#oldc...
update_depot_tools.bat:32: python -u bootstrap\bootstrap.py --deps_file
bootstrap\deps.pyl --quiet ENV
Please re-add --quiet. Otherwise, this will break some tools, e.g. blink_roller
that expects that 'gclient revinfo' only prints repo paths and their source
repos.

[Daniel Bratell, 2015-07-20 09:04:21]

Ah yes. Just leaving some debug output in for the reviewer to catch. :-)

https://codereview.chromium.org/1242013003/diff/1/update_depot_tools.bat
File update_depot_tools.bat (left):

https://codereview.chromium.org/1242013003/diff/1/update_depot_tools.bat#oldc...
update_depot_tools.bat:32: python -u bootstrap\bootstrap.py --deps_file
bootstrap\deps.pyl --quiet ENV
On 2015/07/20 08:57:18, Sergiy Byelozyorov wrote:
> Please re-add --quiet. Otherwise, this will break some tools, e.g.
blink_roller
> that expects that 'gclient revinfo' only prints repo paths and their source
> repos.

Done.

[Daniel Bratell, 2015-07-20 09:05:41]

On 2015/07/20 08:57:18, Sergiy Byelozyorov wrote:
> Thanks a lot of for fixing this. I was not aware Windows users didn't have
their
> depot_tools updated since my CL and just hope that depot_tools will still work
> for them after the update actually happens.

Bots are using newer versions of depot_tools so it can't be all broken. I just
noticed it because I had a too old ninja version.

[Sergiy Byelozyorov, 2015-07-20 09:07:43]

lgtm

[Daniel Bratell, 2015-07-20 09:13:39]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2015-07-20 09:13:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1242013003/20001

[commit-bot: I haz the power, 2015-07-20 09:15:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-20 09:15:55]

Try jobs failed on following builders:
  depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_pre...)

[Daniel Bratell, 2015-07-20 09:27:33]

CQ doesn't seem to like the patch. The patch is based on the newest
origin/master so my best guess is that there is something with linebreaks. .bat
files have to be CRLF (and I worked in CRLF) but I have a small memory of CQ
having problem with files with CRLF in them.

sergiyb, any suggestion?

[Sergiy Byelozyorov, 2015-07-20 09:55:58]

On 2015/07/20 09:27:33, Daniel Bratell wrote:
> CQ doesn't seem to like the patch. The patch is based on the newest
> origin/master so my best guess is that there is something with linebreaks.
.bat
> files have to be CRLF (and I worked in CRLF) but I have a small memory of CQ
> having problem with files with CRLF in them.
> 
> sergiyb, any suggestion?

Yes, Rietveld automatically converts CRLF to LF and bots fail to apply the
patch. git cl land please.

[Daniel Bratell, 2015-07-20 11:04:24]

On 2015/07/20 09:55:58, Sergiy Byelozyorov wrote:
> On 2015/07/20 09:27:33, Daniel Bratell wrote:
> > CQ doesn't seem to like the patch. The patch is based on the newest
> > origin/master so my best guess is that there is something with linebreaks.
> .bat
> > files have to be CRLF (and I worked in CRLF) but I have a small memory of CQ
> > having problem with files with CRLF in them.
> > 
> > sergiyb, any suggestion?
> 
> Yes, Rietveld automatically converts CRLF to LF and bots fail to apply the
> patch. git cl land please.

Ah, then I might need your help. I don't have the committer bit set so I do not
think I can do it. Though I got
Missing LGTM from an OWNER for these files: update_depot_tools.bat
when I tried so maybe more people need to be involved.

[Sergiy Byelozyorov, 2015-07-20 11:12:40]

sergiyb@chromium.org changed reviewers:
+ pgervais@chromium.org

[Sergiy Byelozyorov, 2015-07-20 11:12:41]

+pgervais for owners

[Sergiy Byelozyorov, 2015-07-20 11:19:41]

On 2015/07/20 11:12:41, Sergiy Byelozyorov wrote:
> +pgervais for owners

Hm... I can't apply the patch locally for the same reasons it can't be tried on
trybots. I've created a new CL instead:
https://codereview.chromium.org/1239263003

[Sergiy Byelozyorov, 2015-07-20 11:22:50]

On 2015/07/20 11:19:41, Sergiy Byelozyorov wrote:
> On 2015/07/20 11:12:41, Sergiy Byelozyorov wrote:
> > +pgervais for owners
> 
> Hm... I can't apply the patch locally for the same reasons it can't be tried
on
> trybots. I've created a new CL instead:
> https://codereview.chromium.org/1239263003

Please lgtm it and I'll land it for you. Sorry for the inconvenience.

[Sergiy Byelozyorov, 2015-07-20 11:56:48]

On 2015/07/20 11:22:50, Sergiy Byelozyorov wrote:
> On 2015/07/20 11:19:41, Sergiy Byelozyorov wrote:
> > On 2015/07/20 11:12:41, Sergiy Byelozyorov wrote:
> > > +pgervais for owners
> > 
> > Hm... I can't apply the patch locally for the same reasons it can't be tried
> on
> > trybots. I've created a new CL instead:
> > https://codereview.chromium.org/1239263003
> 
> Please lgtm it and I'll land it for you. Sorry for the inconvenience.

The replacement CL was landed: https://codereview.chromium.org/1239263003