Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 1242013002: MIPS64: Fix 'Expose SIMD.Float32x4 type to Javascript.' (Closed)

Created:
5 years, 5 months ago by balazs.kilvady
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix 'Expose SIMD.Float32x4 type to Javascript.' Port e5ed3bee99807c502fa7d7a367ec401e16d3f773 Original commit message: This CL exposes the constructor function, defines type related information, and implements value type semantics. It also refactors test/mjsunit/samevalue.js to test SameValue and SameValueZero. TEST=test/mjsunit/harmony/simd.js, test/cctest/test-simd.cc LOG=Y BUG=v8:4124

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
balazs.kilvady
5 years, 5 months ago (2015-07-16 10:57:38 UTC) #2
bbudge
Thanks for catching this. My change got reverted and I'm trying to reland it. I ...
5 years, 5 months ago (2015-07-16 15:56:04 UTC) #3
balazs.kilvady
On 2015/07/16 15:56:04, bbudge wrote: > Thanks for catching this. > > My change got ...
5 years, 5 months ago (2015-07-16 16:38:31 UTC) #4
bbudge
5 years, 5 months ago (2015-07-16 16:50:41 UTC) #5
I omitted that stub unintentionally. I was actually trying to make all
architectures work.

I will reland with your patch included. Thanks again!

Powered by Google App Engine
This is Rietveld 408576698