Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1241953010: Properly fix enumerate / Object.keys wrt access checked objects (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Properly fix enumerate / Object.keys wrt access checked objects BUG=chromium:509936 LOG=y Committed: https://crrev.com/8c448805449aa603f5554a39d8fe4ee9ec21d4a8 Cr-Commit-Position: refs/heads/master@{#29733}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -26 lines) Patch
M src/objects.cc View 2 3 chunks +9 lines, -6 lines 0 comments Download
M src/runtime/runtime-object.cc View 2 1 chunk +0 lines, -14 lines 0 comments Download
M test/cctest/test-api.cc View 1 5 chunks +44 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-17 12:56:36 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-17 12:59:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241953010/40001
5 years, 5 months ago (2015-07-17 13:43:44 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-17 14:11:49 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 14:12:03 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8c448805449aa603f5554a39d8fe4ee9ec21d4a8
Cr-Commit-Position: refs/heads/master@{#29733}

Powered by Google App Engine
This is Rietveld 408576698