Issue 124193003: Remove DOMSelection::setPosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 124193003: Remove DOMSelection::setPosition (Closed)

Created:
6 years, 11 months ago by rwlbuis

Modified:
6 years, 11 months ago

Reviewers:
Inactive

CC:
blink-reviews, arv+blink, Inactive, watchdog-blink-watchlist_google.com

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Remove DOMSelection::setPosition This method shares the same implementation as DOMSelection::collapse, so make the bindings use that one instead. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164631

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -18 lines)			Patch
M	Source/core/page/DOMSelection.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/page/DOMSelection.cpp	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	Source/core/page/Selection.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/124193003/1

6 years, 11 months ago (2014-01-07 21:02:52 UTC) #3

Message was sent while issue was closed.

Change committed as 164631