Add histograms for DHCP lease expiry

Add histograms for DHCP lease expiry

Add per-network-technology histograms that will be emitted by
shill whenever a lease expires before it can be renewed.

R=isherman@chromium.org
BUG=216710
TEST=Start chrome, and browse to chrome://histograms to make sure
these enums now exist.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243772

[Ilya Sherman, 2014-01-08 05:42:21]

LGTM % nits.

https://codereview.chromium.org/124193002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/124193002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:10831: +    Chrome OS network
performance metric that tracks the the length of a lease
nit: "the the" -> "the"

https://codereview.chromium.org/124193002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:10832: +    for an cellular network at
the time it expired without the DHCP client being
nit: "an cellular" -> "a cellular"

https://codereview.chromium.org/124193002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:10968: +    Chrome OS network
performance metric that tracks the the length of a lease
nit: "the the" -> "the"

https://codereview.chromium.org/124193002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:11245: +    Chrome OS network
performance metric that tracks the the length of a lease
nit: "the the" -> "the"

https://codereview.chromium.org/124193002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:11449: +    Chrome OS network
performance metric that tracks the the length of a lease
nit: "the the" -> "the"

[Paul Stewart, 2014-01-08 16:45:39]

Thanks Ilya.  PTAL.

https://codereview.chromium.org/124193002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/124193002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:10831: +    Chrome OS network
performance metric that tracks the the length of a lease
On 2014/01/08 05:42:21, Ilya Sherman (Away Jan11-Feb2) wrote:
> nit: "the the" -> "the"

Done, and found a few others in this file unrelated to this CL.

https://codereview.chromium.org/124193002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:10832: +    for an cellular network at
the time it expired without the DHCP client being
On 2014/01/08 05:42:21, Ilya Sherman (Away Jan11-Feb2) wrote:
> nit: "an cellular" -> "a cellular"

Done.

https://codereview.chromium.org/124193002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:10968: +    Chrome OS network
performance metric that tracks the the length of a lease
On 2014/01/08 05:42:21, Ilya Sherman (Away Jan11-Feb2) wrote:
> nit: "the the" -> "the"

Done.

https://codereview.chromium.org/124193002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:11245: +    Chrome OS network
performance metric that tracks the the length of a lease
On 2014/01/08 05:42:21, Ilya Sherman (Away Jan11-Feb2) wrote:
> nit: "the the" -> "the"

Done.

https://codereview.chromium.org/124193002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:11449: +    Chrome OS network
performance metric that tracks the the length of a lease
On 2014/01/08 05:42:21, Ilya Sherman (Away Jan11-Feb2) wrote:
> nit: "the the" -> "the"

Done.

[Ilya Sherman, 2014-01-08 22:55:56]

Still LGTM

[commit-bot: I haz the power, 2014-01-08 22:57:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pstew@chromium.org/124193002/70001

[commit-bot: I haz the power, 2014-01-09 04:44:38]

Change committed as 243772