Work around unreliable metadata for HLS in WebMediaPlayerAndroid

Work around unreliable metadata for HLS in WebMediaPlayerAndroid

There are two bugs involved, both specific to HLS:
 1. MediaPlayer.getDuration() returning 0 as opposed to -1.
 2. The MediaPlayer.OnVideoSizeChangedListener callback being called
    with width and height zero and later with a non-zero size.

Logging statements were used to test for the bugs on
http://www.aljazeera.com/watch_now/ with some different devices:
 * Huawei P6-U06, Android 4.2.2: both bugs
 * Samsung Galaxy S Duos 2, Android 4.2.2: duration bug
 * HTC One, Android 4.3: both bugs
 * Sony Xperia CP C5303, Android 4.3: both bugs
 * Samsung Galaxy S III, Android 4.3: duration bug
 * Samsung Galaxy S4, Android 4.4.2: duration bug
 * Samsung Galaxy Young 2, Android 4.4.2: duration bug
 * Samsung Galaxy Grand Prime, Android 4.4.4: duration bug
 * Sony Xperia Z2, Android 5.0.2: duration bug
 * Samsung Galaxy S4, CyanogenMod 12.1, Android 5.1.1: duration bug

In summary, the duration bug affects every device tested, while the
video size bug seems to affect some but not all devices running
Android 4.3 and older.

Avoid the need for a local duration variable in OnMediaMetadataChanged
by passing its argument by value, which is already the case for all
other OnMediaMetadataChanged methods in the code base.

BUG=501213, 509972
R=qinmin@chromium.org

Committed: https://crrev.com/e95e3c68fffcac8ca62cb4d0269c7a867bcd02ff
Cr-Commit-Position: refs/heads/master@{#339019}

[philipj_slow, 2015-07-15 16:37:22]

The CQ bit was checked by philipj@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-15 16:38:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1241923003/1

[philipj_slow, 2015-07-15 16:40:16]

PTAL. In addition to the testing mentioned in the description I've also verified
separately that the original problem of a true->false->true sequence of the
hasVideo() return value is gone, now it's always true, and there's no change to
the <video src=audio.ogv> case.

[commit-bot: I haz the power, 2015-07-15 17:51:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 17:51:08]

Dry run: This issue passed the CQ dry run.

[qinmin, 2015-07-16 03:20:07]

https://codereview.chromium.org/1241923003/diff/1/content/renderer/media/andr...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/1241923003/diff/1/content/renderer/media/andr...
content/renderer/media/android/webmediaplayer_android.cc:865: if (width == 0 &&
height == 0 && IsHLSStream())
do we need to check whether natural_size_ is non empty? Not sure if there are
cases that the size can change from non-empty to empty.

[philipj_slow, 2015-07-16 08:16:40]

PTAL. I've retested that it still fixes the issues with
https://www.aljazeera.com/watch_now/

https://codereview.chromium.org/1241923003/diff/1/content/renderer/media/andr...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/1241923003/diff/1/content/renderer/media/andr...
content/renderer/media/android/webmediaplayer_android.cc:865: if (width == 0 &&
height == 0 && IsHLSStream())
On 2015/07/16 03:20:07, qinmin wrote:
> do we need to check whether natural_size_ is non empty? Not sure if there are
> cases that the size can change from non-empty to empty.

I also wasn't sure about this. I think it's pretty unlikely, but I added a
has_size_info_ check so that if an HLS stream first reports a non-empty size and
then later an empty size, we'll treat that as the video stream ending and return
false for hasVideo().

[qinmin, 2015-07-16 12:26:14]

lgtm

[philipj_slow, 2015-07-16 12:32:50]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-07-16 12:32:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1241923003/20001

[commit-bot: I haz the power, 2015-07-16 13:18:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-16 13:19:37]

Patchset 2 (id:??) landed as
https://crrev.com/e95e3c68fffcac8ca62cb4d0269c7a867bcd02ff
Cr-Commit-Position: refs/heads/master@{#339019}