Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: runtime/vm/assembler_mips.h

Issue 1241863002: VM: Refactor allocation stats code and remove duplicate code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/assembler_ia32.cc ('k') | runtime/vm/assembler_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_ASSEMBLER_MIPS_H_ 5 #ifndef VM_ASSEMBLER_MIPS_H_
6 #define VM_ASSEMBLER_MIPS_H_ 6 #define VM_ASSEMBLER_MIPS_H_
7 7
8 #ifndef VM_ASSEMBLER_H_ 8 #ifndef VM_ASSEMBLER_H_
9 #error Do not include assembler_mips.h directly; use assembler.h instead. 9 #error Do not include assembler_mips.h directly; use assembler.h instead.
10 #endif 10 #endif
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 // to set up the frame and save a PC which can be used to figure out the 297 // to set up the frame and save a PC which can be used to figure out the
298 // RawInstruction object corresponding to the code running in the frame. 298 // RawInstruction object corresponding to the code running in the frame.
299 // See EnterDartFrame. There are 6 instructions before we know the PC. 299 // See EnterDartFrame. There are 6 instructions before we know the PC.
300 static const intptr_t kEntryPointToPcMarkerOffset = 6 * Instr::kInstrSize; 300 static const intptr_t kEntryPointToPcMarkerOffset = 6 * Instr::kInstrSize;
301 static intptr_t EntryPointToPcMarkerOffset() { 301 static intptr_t EntryPointToPcMarkerOffset() {
302 return kEntryPointToPcMarkerOffset; 302 return kEntryPointToPcMarkerOffset;
303 } 303 }
304 304
305 void UpdateAllocationStats(intptr_t cid, 305 void UpdateAllocationStats(intptr_t cid,
306 Register temp_reg, 306 Register temp_reg,
307 Heap::Space space); 307 Heap::Space space,
308 bool inline_isolate = true);
308 309
309 void UpdateAllocationStatsWithSize(intptr_t cid, 310 void UpdateAllocationStatsWithSize(intptr_t cid,
310 Register size_reg, 311 Register size_reg,
311 Register temp_reg, 312 Register temp_reg,
312 Heap::Space space); 313 Heap::Space space,
314 bool inline_isolate = true);
313 315
314 316
315 void MaybeTraceAllocation(intptr_t cid, 317 void MaybeTraceAllocation(intptr_t cid,
316 Register temp_reg, 318 Register temp_reg,
317 Label* trace); 319 Label* trace);
318 320
319 // Inlined allocation of an instance of class 'cls', code has no runtime 321 // Inlined allocation of an instance of class 'cls', code has no runtime
320 // calls. Jump to 'failure' if the instance cannot be allocated here. 322 // calls. Jump to 'failure' if the instance cannot be allocated here.
321 // Allocated instance is returned in 'instance_reg'. 323 // Allocated instance is returned in 'instance_reg'.
322 // Only the tags field of the object is initialized. 324 // Only the tags field of the object is initialized.
(...skipping 1434 matching lines...) Expand 10 before | Expand all | Expand 10 after
1757 Register value, 1759 Register value,
1758 Label* no_update); 1760 Label* no_update);
1759 1761
1760 DISALLOW_ALLOCATION(); 1762 DISALLOW_ALLOCATION();
1761 DISALLOW_COPY_AND_ASSIGN(Assembler); 1763 DISALLOW_COPY_AND_ASSIGN(Assembler);
1762 }; 1764 };
1763 1765
1764 } // namespace dart 1766 } // namespace dart
1765 1767
1766 #endif // VM_ASSEMBLER_MIPS_H_ 1768 #endif // VM_ASSEMBLER_MIPS_H_
OLDNEW
« no previous file with comments | « runtime/vm/assembler_ia32.cc ('k') | runtime/vm/assembler_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698