Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5482)

Unified Diff: chrome/browser/browsing_data/browsing_data_database_helper_unittest.cc

Issue 124183002: Implement delete methods for the various CannedBrowsingDataHelpers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_database_helper_unittest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_database_helper_unittest.cc b/chrome/browser/browsing_data/browsing_data_database_helper_unittest.cc
index 276cb89debbe716d3084e5b78e59cb1378af4a13..0663ee05f1cd80c796f83d4f58baacd2edf4afc0 100644
--- a/chrome/browser/browsing_data/browsing_data_database_helper_unittest.cc
+++ b/chrome/browser/browsing_data/browsing_data_database_helper_unittest.cc
@@ -7,9 +7,12 @@
#include "chrome/test/base/testing_profile.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "webkit/common/database/database_identifier.h"
namespace {
+using webkit_database::DatabaseIdentifier;
+
class CannedBrowsingDataDatabaseHelperTest : public testing::Test {
content::TestBrowserThreadBundle thread_bundle_;
};
@@ -30,6 +33,34 @@ TEST_F(CannedBrowsingDataDatabaseHelperTest, Empty) {
ASSERT_TRUE(helper->empty());
}
+TEST_F(CannedBrowsingDataDatabaseHelperTest, Delete) {
+ TestingProfile profile;
+
+ const GURL origin1("http://host1:9000");
+ const char db1[] = "db1";
+
+ const GURL origin2("http://example.com");
+ const char db2[] = "db2";
+
+ const GURL origin3("http://foo.example.com");
+ const char db3[] = "db3";
+
+ scoped_refptr<CannedBrowsingDataDatabaseHelper> helper(
+ new CannedBrowsingDataDatabaseHelper(&profile));
+
+ EXPECT_TRUE(helper->empty());
+ helper->AddDatabase(origin1, db1, std::string());
+ helper->AddDatabase(origin2, db2, std::string());
+ helper->AddDatabase(origin3, db3, std::string());
+ EXPECT_EQ(3u, helper->GetDatabaseCount());
+ helper->DeleteDatabase(
+ DatabaseIdentifier::CreateFromOrigin(origin2).ToString(), db1);
+ EXPECT_EQ(3u, helper->GetDatabaseCount());
+ helper->DeleteDatabase(
+ DatabaseIdentifier::CreateFromOrigin(origin2).ToString(), db2);
+ EXPECT_EQ(2u, helper->GetDatabaseCount());
+}
+
TEST_F(CannedBrowsingDataDatabaseHelperTest, IgnoreExtensionsAndDevTools) {
TestingProfile profile;

Powered by Google App Engine
This is Rietveld 408576698