Add UMA metrics for Bookmark widgets.

Add UMA metrics for Bookmark widgets.

- Adds UMA for when Bookmark Navigator and Bookmark Shortcut widgets get added.
- Adds new EXTRA_SOURCE types for Bookmark Navigator and Bookmark Shortcut
  widgets.

BUG=447706
Committed: https://crrev.com/9dfb76c42a8447c04d29dc70c3d08c39c91c6a77
Cr-Commit-Position: refs/heads/master@{#339147}

[aurimas (slooooooooow), 2015-07-15 01:30:40]

aurimas@chromium.org changed reviewers:
+ dominickn@chromium.org, newt@chromium.org

[aurimas (slooooooooow), 2015-07-15 01:30:41]

+newt for chrome/android/java changes
+dominickn for chrome/browser/android changes

[dominickn, 2015-07-15 01:55:34]

chrome/browser/android LGTM

I'll revisit https://codereview.chromium.org/1220813010/ and change everything
to use the autogenerated enum rather than the constant in ShortcutHelper.java.

[newt (away), 2015-07-15 02:56:00]

At last, we'll have stats for these :)

A few comments inline.

https://codereview.chromium.org/1241823002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetService.java
(right):

https://codereview.chromium.org/1241823002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetService.java:168:
private void recordWidgetAdded() {
I'd call this something like maybeRecordWidgetAdded() since this method gets
called lot (e.g. every time the device is restarted, or whenever the user clicks
a folder inside the widget and Chrome isn't running), and every time except the
first, it won't record anything. It's probably also worth commenting that you're
using the absence of STATE_CURRENT_FOLDER to signal that the widget is new. Or
you could rename this method to isWidgetNewlyCreated() and put this code in
onCreate():

  if (isWidgetNewlyCreated()) {
    RecordUserAction.record("BookmarkNavigatorWidgetAdded");
  }

That seems clear enough not to need many/any comments.

https://codereview.chromium.org/1241823002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetProxy.java
(right):

https://codereview.chromium.org/1241823002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetProxy.java:30:
view.setComponent(null);
This line isn't needed anymore since setClass() overrides the component value.

https://codereview.chromium.org/1241823002/diff/1/chrome/browser/android/shor...
File chrome/browser/android/shortcut_info.h (right):

https://codereview.chromium.org/1241823002/diff/1/chrome/browser/android/shor...
chrome/browser/android/shortcut_info.h:19: // GENERATED_JAVA_ENUM_PACKAGE:
org.chromium.chrome.browser
Source is a very generic name. Let's generate the Java enum into something more
explicit, say, ShortcutSource. You can do this by adding another tag like
GENERATED_JAVA_ENUM_PACKAGE. See java_cpp_enum_tests.py for examples:
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/gyp/...

[aurimas (slooooooooow), 2015-07-16 01:15:31]

https://chromiumcodereview.appspot.com/1241823002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetService.java
(right):

https://chromiumcodereview.appspot.com/1241823002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetService.java:168:
private void recordWidgetAdded() {
On 2015/07/15 at 02:56:00, newt wrote:
> I'd call this something like maybeRecordWidgetAdded() since this method gets
called lot (e.g. every time the device is restarted, or whenever the user clicks
a folder inside the widget and Chrome isn't running), and every time except the
first, it won't record anything. It's probably also worth commenting that you're
using the absence of STATE_CURRENT_FOLDER to signal that the widget is new. Or
you could rename this method to isWidgetNewlyCreated() and put this code in
onCreate():
> 
>   if (isWidgetNewlyCreated()) {
>     RecordUserAction.record("BookmarkNavigatorWidgetAdded");
>   }
> 
> That seems clear enough not to need many/any comments.

Done

https://chromiumcodereview.appspot.com/1241823002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetProxy.java
(right):

https://chromiumcodereview.appspot.com/1241823002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetProxy.java:30:
view.setComponent(null);
On 2015/07/15 at 02:56:00, newt wrote:
> This line isn't needed anymore since setClass() overrides the component value.

Done

https://chromiumcodereview.appspot.com/1241823002/diff/1/chrome/browser/andro...
File chrome/browser/android/shortcut_info.h (right):

https://chromiumcodereview.appspot.com/1241823002/diff/1/chrome/browser/andro...
chrome/browser/android/shortcut_info.h:19: // GENERATED_JAVA_ENUM_PACKAGE:
org.chromium.chrome.browser
On 2015/07/15 at 02:56:00, newt wrote:
> Source is a very generic name. Let's generate the Java enum into something
more explicit, say, ShortcutSource. You can do this by adding another tag like
GENERATED_JAVA_ENUM_PACKAGE. See java_cpp_enum_tests.py for examples:
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/gyp/...

Done

https://chromiumcodereview.appspot.com/1241823002/diff/1/chrome/browser/andro...
chrome/browser/android/shortcut_info.h:19: // GENERATED_JAVA_ENUM_PACKAGE:
org.chromium.chrome.browser
On 2015/07/15 at 02:56:00, newt wrote:
> Source is a very generic name. Let's generate the Java enum into something
more explicit, say, ShortcutSource. You can do this by adding another tag like
GENERATED_JAVA_ENUM_PACKAGE. See java_cpp_enum_tests.py for examples:
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/gyp/...

Done

[newt (away), 2015-07-16 01:18:00]

lgtm

[aurimas (slooooooooow), 2015-07-16 01:30:05]

aurimas@chromium.org changed reviewers:
+ asvitkine@chromium.org

[aurimas (slooooooooow), 2015-07-16 01:30:05]

+asvitkine for changes in tools/metrics/* and
chrome/browser/android/metrics/launch_metrics.cc

[aurimas (slooooooooow), 2015-07-16 01:30:10]

The CQ bit was checked by aurimas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-16 01:30:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1241823002/40001

[commit-bot: I haz the power, 2015-07-16 04:19:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-16 04:19:50]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Alexei Svitkine (slow), 2015-07-16 14:49:45]

lgtm

[aurimas (slooooooooow), 2015-07-16 14:58:42]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-07-16 14:58:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org, newt@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1241823002/#ps40001
(title: "Updated Histograms and Rappor")

[commit-bot: I haz the power, 2015-07-16 14:59:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1241823002/40001

[commit-bot: I haz the power, 2015-07-16 15:08:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-16 15:08:55]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[aurimas (slooooooooow), 2015-07-16 15:11:22]

+thakis for chrome/chrome.gyp

[aurimas (slooooooooow), 2015-07-16 15:11:53]

aurimas@chromium.org changed reviewers:
+ thakis@chromium.org

[aurimas (slooooooooow), 2015-07-16 15:11:53]

Actually add +thakis for chrome/chrome.gyp

[Nico, 2015-07-16 20:26:26]

lgtm

https://codereview.chromium.org/1241823002/diff/40001/chrome/android/BUILD.gn
File chrome/android/BUILD.gn (right):

https://codereview.chromium.org/1241823002/diff/40001/chrome/android/BUILD.gn...
chrome/android/BUILD.gn:178: # GYP:
//chrome/chrome_browser.gypi:tab_load_status_java
add shortcut_source_java here?

[aurimas (slooooooooow), 2015-07-16 20:29:52]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-07-16 20:29:53]

https://codereview.chromium.org/1241823002/diff/40001/chrome/android/BUILD.gn
File chrome/android/BUILD.gn (right):

https://codereview.chromium.org/1241823002/diff/40001/chrome/android/BUILD.gn...
chrome/android/BUILD.gn:178: # GYP:
//chrome/chrome_browser.gypi:tab_load_status_java
On 2015/07/16 at 20:26:26, Nico wrote:
> add shortcut_source_java here?

Done

[aurimas (slooooooooow), 2015-07-16 20:29:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org, thakis@chromium.org, asvitkine@chromium.org,
newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1241823002/#ps60001
(title: "Nico's nit")

[commit-bot: I haz the power, 2015-07-16 20:35:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1241823002/60001

[commit-bot: I haz the power, 2015-07-16 22:55:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-16 22:56:51]

Patchset 4 (id:??) landed as
https://crrev.com/9dfb76c42a8447c04d29dc70c3d08c39c91c6a77
Cr-Commit-Position: refs/heads/master@{#339147}