Issue 1241763003: Add a few include rules for XFA-specific files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1241763003: Add a few include rules for XFA-specific files. (Closed)

Created:
5 years, 5 months ago by Tom Sepez

Modified:
5 years, 5 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Add a few include rules for XFA-specific files. Checkdeps is still pretty noisy on XFA. There is some confusion about finding include files since not all are relative. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/a4755c6c899c6d29b01b1a0a58dac20b65d361dc

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	fpdfsdk/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A +	xfa/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (1 generated)

Tom Sepez

The important thing to note is the layering: fpdfsdk -> xfa -> core

5 years, 5 months ago (2015-07-14 23:30:36 UTC) #3

Tom Sepez

5 years, 5 months ago (2015-07-14 23:39:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a4755c6c899c6d29b01b1a0a58dac20b65d361dc (presubmit successful).